[GitHub] [pinot] walterddr commented on a diff in pull request #9726: [multistage] test restructure

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9726:
URL: https://github.com/apache/pinot/pull/9726#discussion_r1014094719


##########
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTestBase.java:
##########
@@ -71,4 +98,42 @@ protected Object[][] provideQueries() {
             + " b.col2 NOT IN ('alice', 'charlie')"},
     };
   }
+
+  public static List<GenericRow> buildRows(String tableName) {
+    List<GenericRow> rows = new ArrayList<>(NUM_ROWS);
+    for (int i = 0; i < NUM_ROWS; i++) {

Review Comment:
   good catch. will do



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org