You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2015/09/30 06:02:12 UTC

[GitHub] tajo pull request: TAJO-1899: Calling 'Arrays.asList()' with too f...

GitHub user dkhwangbo opened a pull request:

    https://github.com/apache/tajo/pull/794

    TAJO-1899: Calling 'Arrays.asList()' with too few arguments cause memory extravagance

    Reports any calls to Arrays.asList() with zero arguments or only one argument.
    Such calls could be replaced with either a call to Collections.singletonList() or Collections.emptyList() which will save some memory.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dkhwangbo/tajo TAJO-1899

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/794.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #794
    
----
commit 268c6cade0bb1b864ddea9a7f13bc2561040acaa
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date:   2015-09-30T03:52:49Z

    initial commit

commit 5262eba22751741a617fe55aaa461ab720de80d8
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date:   2015-09-30T03:57:47Z

    modify import

commit 6e27a7bb7e849909ae0a889e5bfaf33cba0896e3
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date:   2015-09-30T03:59:49Z

    rollback unnecessarily difference

commit adf6eb1b06bd214db4f5ce707402e79c77ffa03a
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date:   2015-09-30T04:01:32Z

    rollback unnecessarily difference

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1899: Calling 'Arrays.asList()' with too f...

Posted by jihoonson <gi...@git.apache.org>.

Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/794#issuecomment-145524421
  
    +1 LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1899: Calling 'Arrays.asList()' with too f...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/794


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---