[jira] [Created] (HDFS-12668) MetricsSystemImpl should consistently check minicluster mode

["Xiao Chen (JIRA)" <ji...@apache.org>]

Xiao Chen created HDFS-12668:
--------------------------------

             Summary: MetricsSystemImpl should consistently check minicluster mode
                 Key: HDFS-12668
                 URL: https://issues.apache.org/jira/browse/HDFS-12668
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: test
            Reporter: Xiao Chen
            Priority: Minor


Found this when writing some tests related to JvmMetrics.
It appears {{JvmMetrics.initSingleton}} twice in minicluster works, but {{JvmMetrics.create}} twice doesn't.

This jira suggests to investigate whether this is intentional, and likely make the check of {{DefaultMetricsSystem.inMiniClusterMode()}} consistent in {{MetricsSystemImpl}} to ease testing.

{noformat}
org.apache.hadoop.metrics2.MetricsException: Metrics source JvmMetrics already exists!
        at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newSourceName(DefaultMetricsSystem.java:152)
        at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.sourceName(DefaultMetricsSystem.java:125)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.register(MetricsSystemImpl.java:229)
        at org.apache.hadoop.metrics2.source.JvmMetrics.create(JvmMetrics.java:95)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org