You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/31 16:12:56 UTC
[GitHub] [airflow] potiuk opened a new pull request #22656: Fix file permissions in all build commands
potiuk opened a new pull request #22656:
URL: https://github.com/apache/airflow/pull/22656
Seems that we should fix group permissions in all build commands.
That will shave extra few minutes on most builds where they
modify sources. Also the output from the build will be a bit
cleaner by removing come of the console outputs.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #22656: Fix file permissions in all build commands
Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #22656:
URL: https://github.com/apache/airflow/pull/22656#issuecomment-1084962829
@potiuk this is impressive 💪🏼 , If I want to test this, should I install Breeze, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22656: Fix file permissions in all build commands
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22656:
URL: https://github.com/apache/airflow/pull/22656#issuecomment-1084959795
2 minutes per build saved with it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22656: Fix file permissions in all build commands
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22656:
URL: https://github.com/apache/airflow/pull/22656#issuecomment-1084804842
cc: @bowrna @edithturn - seems that I am ready to start replacing the old Breeze code with this one :). Watch this space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22656: Fix file permissions in all build commands
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22656:
URL: https://github.com/apache/airflow/pull/22656#issuecomment-1084964781
Naaa. I tested it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22656: Fix file permissions in all build commands
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22656:
URL: https://github.com/apache/airflow/pull/22656#issuecomment-1084963480
> @potiuk this is impressive 💪🏼 , If I want to test this, should I install Breeze, right?
Yep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22656: Fix file permissions in all build commands
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22656:
URL: https://github.com/apache/airflow/pull/22656#issuecomment-1084803087
@dstandish - few more minutes saved in some cases with this one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22656: Fix file permissions in all build commands
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22656:
URL: https://github.com/apache/airflow/pull/22656#issuecomment-1085102927
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #22656: Fix file permissions in all build commands
Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #22656:
URL: https://github.com/apache/airflow/pull/22656#issuecomment-1084963951
> cc: @Bowrna @edithturn - seems that I am ready to start replacing the old Breeze code with this one :). Watch this space.
what more do you need @potiuk, could I help with the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22656: Fix file permissions in all build commands
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22656:
URL: https://github.com/apache/airflow/pull/22656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org