You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2013/10/24 02:39:39 UTC
Review Request 14895: [HELIX-277] FULL_AUTO rebalancer should not prefer
nodes that are just coming up
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14895/
-----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-277
Repository: helix-git
Description
-------
This is the first part of a two-part fix of HELIX-276. The second part (HELIX-278) involves creating an API surrounding this functionality to make it configurable.
commit 90faf91bb87594c67be23a1e4547e81f58ea7c8e
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Wed Oct 23 17:36:15 2013 -0700
[HELIX-277] FULL_AUTO rebalancer should not prefer nodes that are just coming up
:100644 100644 3eb258b... 946dd5e... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java
:100644 100644 72046bf... cc5acb7... M helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java
:100644 100644 9fb7ba9... e47032e... M helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java 3eb258b
helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java 72046bf
helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java 9fb7ba9
Diff: https://reviews.apache.org/r/14895/diff/
Testing
-------
Existing tests all pass, new test passes.
Thanks,
Kanak Biscuitwala
Re: Review Request 14895: [HELIX-277] FULL_AUTO rebalancer should not prefer
nodes that are just coming up
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14895/#review27573
-----------------------------------------------------------
Ship it!
Ship It!
- Kishore Gopalakrishna
On Oct. 24, 2013, 12:39 a.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14895/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2013, 12:39 a.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-277
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> This is the first part of a two-part fix of HELIX-276. The second part (HELIX-278) involves creating an API surrounding this functionality to make it configurable.
>
> commit 90faf91bb87594c67be23a1e4547e81f58ea7c8e
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Wed Oct 23 17:36:15 2013 -0700
>
> [HELIX-277] FULL_AUTO rebalancer should not prefer nodes that are just coming up
>
> :100644 100644 3eb258b... 946dd5e... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java
> :100644 100644 72046bf... cc5acb7... M helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java
> :100644 100644 9fb7ba9... e47032e... M helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java 3eb258b
> helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java 72046bf
> helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java 9fb7ba9
>
> Diff: https://reviews.apache.org/r/14895/diff/
>
>
> Testing
> -------
>
> Existing tests all pass, new test passes.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>