You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/23 19:48:30 UTC
[GitHub] [geode] mivanac opened a new pull request #6048: GEODE-8956: added thread pool to LocatorMembershipListener
mivanac opened a new pull request #6048:
URL: https://github.com/apache/geode/pull/6048
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [*] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [*] Is your initial contribution a single, squashed commit?
- [*] Does `gradlew build` run cleanly?
- [*] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #6048: GEODE-8956: added thread pool to LocatorMembershipListener
Posted by GitBox <gi...@apache.org>.
mivanac commented on pull request #6048:
URL: https://github.com/apache/geode/pull/6048#issuecomment-796629962
Hi @onichols-pivotal , @Bill , @gesterzhou and @boglesby can you review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #6048: GEODE-8956: added thread pool to LocatorMembershipListener
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #6048:
URL: https://github.com/apache/geode/pull/6048#discussion_r583002834
##########
File path: geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java
##########
@@ -170,6 +207,28 @@ private synchronized Object updateAllLocatorInfo(RemoteLocatorJoinRequest reques
return new RemoteLocatorJoinResponse(this.getAllLocatorsInfo());
}
+ private ExecutorService createThreadPool() {
Review comment:
Are we worried about concurrency in this creation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #6048: GEODE-8956: added thread pool to LocatorMembershipListener
Posted by GitBox <gi...@apache.org>.
mivanac commented on pull request #6048:
URL: https://github.com/apache/geode/pull/6048#issuecomment-801246674
Hi @onichols-pivotal , @Bill , @gesterzhou and @boglesby, just a reminder, could review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #6048: GEODE-8956: added thread pool to LocatorMembershipListener
Posted by GitBox <gi...@apache.org>.
mivanac commented on pull request #6048:
URL: https://github.com/apache/geode/pull/6048#issuecomment-805659196
HI @gesterzhou and @boglesby,
can you review this PR. It is only waiting on your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #6048: GEODE-8956: added thread pool to LocatorMembershipListener
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #6048:
URL: https://github.com/apache/geode/pull/6048#issuecomment-801305778
> Hi @onichols-pivotal , @Bill , @gesterzhou and @boglesby, just a reminder, could review this PR.
Looks like all you still need is a review from @gesterzhou, all others are duplicates of owners that have already approved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac merged pull request #6048: GEODE-8956: added thread pool to LocatorMembershipListener
Posted by GitBox <gi...@apache.org>.
mivanac merged pull request #6048:
URL: https://github.com/apache/geode/pull/6048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on a change in pull request #6048: GEODE-8956: added thread pool to LocatorMembershipListener
Posted by GitBox <gi...@apache.org>.
mivanac commented on a change in pull request #6048:
URL: https://github.com/apache/geode/pull/6048#discussion_r583051737
##########
File path: geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java
##########
@@ -170,6 +207,28 @@ private synchronized Object updateAllLocatorInfo(RemoteLocatorJoinRequest reques
return new RemoteLocatorJoinResponse(this.getAllLocatorsInfo());
}
+ private ExecutorService createThreadPool() {
Review comment:
As current implementation, start() method, is only invoked from InternalLocator constructor. If we are concerned about future use, I can make corrections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org