You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/09/09 17:40:00 UTC
[jira] [Work logged] (BEAM-7009) Add Go SDK test for Standard
Coders using the yaml data.
[ https://issues.apache.org/jira/browse/BEAM-7009?focusedWorklogId=480949&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480949 ]
ASF GitHub Bot logged work on BEAM-7009:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/20 17:39
Start Date: 09/Sep/20 17:39
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #12588:
URL: https://github.com/apache/beam/pull/12588#issuecomment-689714287
R: @tysonjh @youngoli
cc: @TheNeuralBit
I'm finally getting around to fixing the build dep issue with this one, but that will not affect it's ability to be reviewed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 480949)
Time Spent: 1h 10m (was: 1h)
> Add Go SDK test for Standard Coders using the yaml data.
> --------------------------------------------------------
>
> Key: BEAM-7009
> URL: https://issues.apache.org/jira/browse/BEAM-7009
> Project: Beam
> Issue Type: Bug
> Components: beam-model, sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P1
> Labels: stale-P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The Go SDK doesn't currently do this validation, against the standard yaml file. [1]
> The Java and Python equivalents of the test can be found from here [2].
>
> Care would need to be taken so that Beam Go SDK users (such as they are) aren't forced to run them, and not have the yaml file to read. I'd suggest putting it with the integration tests [3].
> The other thing of note is that the Go SDK has no notion of "nested" vs "unnested" coders. All coders are "nested" in the Go SDK, and should have their lengths prefixed to them as appropriate.
> 1: [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml]
> 2: [https://github.com/apache/beam/search?q=standard_coders.yaml&unscoped_q=standard_coders.yaml]
> 3: [https://github.com/apache/beam/tree/master/sdks/go/test |https://github.com/apache/beam/tree/master/sdks/go/test]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)