You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by koushik-das <gi...@git.apache.org> on 2015/08/28 14:32:20 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/760
CLOUDSTACK-8785: Proper enforcement of retry count (max.retries) for …
…all work type handled by HighAvailability manager
Retry count is properly enforced for all work types in HA manager. Also reorganized some of the code for easy testing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/koushik-das/cloudstack CLOUDSTACK-8785
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/760.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #760
----
commit cbf2c3bbf66214ec4a6b6f0666657185446c88ce
Author: Koushik Das <ko...@apache.org>
Date: 2015-08-28T12:29:17Z
CLOUDSTACK-8785: Proper enforcement of retry count (max.retries) for all work type handled by HighAvailability manager
Retry count is properly enforced for all work types in HA manager. Also reorganized some of the code for easy testing.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136696233
2 LGTMs merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136677170
followed the refactored logic, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/760#discussion_r38406769
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -383,10 +383,10 @@ public void scheduleRestart(VMInstanceVO vm, boolean investigate) {
}
List<HaWorkVO> items = _haDao.findPreviousHA(vm.getId());
- int maxRetries = 0;
+ int timesTried = 0;
--- End diff --
I like the rename!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136680502
@DaanHoogland I ran the following integration test on simulator. Other than this I don't thick there is any other test for VM HA.
test/integration/smoke/misc/test_vm_ha.py
Test VM HA ... === TestName: test_vm_ha | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 258.037s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das closed the pull request at:
https://github.com/apache/cloudstack/pull/760
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136673890
Anyone? @kishankavala @bhaisaab @remibergsma @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136675396
in terms of refactorring i like this very much. unit tests and travis pass so LGTM. I haven't done any integration testing, have you @koushik-das
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---