[jira] [Comment Edited] (MESOS-2086) Update messages.proto to use a raw bytestream instead of a string for AuthenticationStartMessage.

["Till Toenshoff (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207905#comment-14207905 ] 

Till Toenshoff edited comment on MESOS-2086 at 11/12/14 10:36 AM:
------------------------------------------------------------------

https://reviews.apache.org/r/27494/ (change introduced)
https://reviews.apache.org/r/27675/ (change documented)


was (Author: tillt):
https://reviews.apache.org/r/27494/

> Update messages.proto to use a raw bytestream instead of a string for AuthenticationStartMessage.
> -------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-2086
>                 URL: https://issues.apache.org/jira/browse/MESOS-2086
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Till Toenshoff
>            Assignee: Till Toenshoff
>
> {{messages.proto}} has to be slightly changed to use a raw bytestream instead of a string for {{AuthenticationStartMessage}} as non CRAM-MD5 authentication mechanisms may transmit binary data.
> *NOTE* that the above change does basically have no impact on C++ based proto code other than the prevention of a warning due to non-UTF8 characters being encoded.
> For more on this subject, please see https://www.mail-archive.com/protobuf@googlegroups.com/msg01486.html
> Even though the above is pretty much determining that we wont run into compatibility issues (old master vs. new slave and vice versa), it still should be tested briefly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)