You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@seata.apache.org by "ptyin (via GitHub)" <gi...@apache.org> on 2024/01/11 03:37:25 UTC
[PR] refactor: refactor saga scaffold to break import cycles [incubator-seata-go]
ptyin opened a new pull request, #647:
URL: https://github.com/apache/incubator-seata-go/pull/647
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Break two import cycles under engine package.
- move `engine/constant` to `constant/constant`. Since constant is such a low-level component, it can be needed everywhere.
- move `process_ctrl/instruction/instruction` to `process_ctrl/instruction`. Instruction is deep coupled with process_ctrl, it needs to be extracted into the parent package.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] refactor: refactor saga scaffold to break import cycles [incubator-seata-go]
Posted by "wt-better (via GitHub)" <gi...@apache.org>.
wt-better merged PR #647:
URL: https://github.com/apache/incubator-seata-go/pull/647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] refactor: refactor saga scaffold to break import cycles [incubator-seata-go]
Posted by "xjlgod (via GitHub)" <gi...@apache.org>.
xjlgod commented on PR #647:
URL: https://github.com/apache/incubator-seata-go/pull/647#issuecomment-1892218999
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org