[jira] [Commented] (THRIFT-4218) Set TCP_NODELAY for PHP client socket

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038719#comment-16038719 ] 

ASF GitHub Bot commented on THRIFT-4218:
----------------------------------------

Github user mfrawley commented on the issue:

    https://github.com/apache/thrift/pull/1283
  
    I'd just like to add that we deployed a similar fix to this on our infrastructure at Jimdo which led to this PR. We have a large PHP codebase which communicates with some services over Thrift. 
     We support ~20 million websites and our logging and metrics indicate fewer timeouts after this change. We had tried several other tweaks previously and this seems to have had a bigger effect than raising the read/write timeouts (at least by a conservative amount).


> Set TCP_NODELAY for PHP client socket
> -------------------------------------
>
>                 Key: THRIFT-4218
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4218
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>            Reporter: Klaus Trainer
>         Attachments: set-tcp_nodelay-for-php-client-socket.patch
>
>
> The PHP client doesn't set the TCP_NODELAY socket option like C++, C#, Ruby, or Java.
> This patch enables TCP_NODELAY for the client socket.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)