[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #4119: YARN-11103. SLS cleanup after previously merged SLS refactor jiras

[GitBox <gi...@apache.org>]

szilard-nemeth commented on a change in pull request #4119:
URL: https://github.com/apache/hadoop/pull/4119#discussion_r838861228



##########
File path: hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/AMRunner.java
##########
@@ -53,7 +53,7 @@
 
 public class AMRunner {
   private static final Logger LOG = LoggerFactory.getLogger(AMRunner.class);
-  static int REMAINING_APPS = 0;
+  static int remainingApps = 0;

Review comment:
       As the spotbugs warning is strictly related to this remainingApps field, I'd prefer to fix it with https://issues.apache.org/jira/browse/YARN-11102




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org