You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/19 08:30:18 UTC
[GitHub] [pulsar] congbobo184 opened a new pull request #12889: [Transaction] Fix transaction system topic create in loop
congbobo184 opened a new pull request #12889:
URL: https://github.com/apache/pulsar/pull/12889
link https://github.com/apache/pulsar/pull/12749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on a change in pull request #12889: [Transaction] Fix transaction system topic create in loop
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on a change in pull request #12889:
URL: https://github.com/apache/pulsar/pull/12889#discussion_r753918523
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##########
@@ -67,6 +67,9 @@ public TopicName load(String name) throws Exception {
public static final TopicName TRANSACTION_COORDINATOR_ASSIGN = TopicName.get(TopicDomain.persistent.value(),
NamespaceName.SYSTEM_NAMESPACE, "transaction_coordinator_assign");
+ public static final TopicName TRANSACTION_COORDINATOR_LOG = TopicName.get(TopicDomain.persistent.value(),
+ NamespaceName.SYSTEM_NAMESPACE, "__transaction_log_");
Review comment:
it ends with an underscore character, because there is a coordinator id behind the `__transaction_log_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #12889: [Transaction] Fix transaction system topic create in loop
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #12889:
URL: https://github.com/apache/pulsar/pull/12889#discussion_r754032016
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -3517,7 +3526,10 @@ private Topic getTopicReference(TopicName topicName) {
} catch (RestException e) {
throw e;
} catch (Exception e) {
- throw new RestException(e);
+ if (e.getCause() instanceof NotAllowedException) {
Review comment:
`NotAllowedException` is related to security problems (authorisation).
why are we rewriting this to "CONFLICT" ? shouldn't it be "FORBIDDEN" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #12889: [Transaction] Fix transaction system topic create in loop
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #12889:
URL: https://github.com/apache/pulsar/pull/12889#discussion_r753077881
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##########
@@ -67,6 +67,9 @@ public TopicName load(String name) throws Exception {
public static final TopicName TRANSACTION_COORDINATOR_ASSIGN = TopicName.get(TopicDomain.persistent.value(),
NamespaceName.SYSTEM_NAMESPACE, "transaction_coordinator_assign");
+ public static final TopicName TRANSACTION_COORDINATOR_LOG = TopicName.get(TopicDomain.persistent.value(),
+ NamespaceName.SYSTEM_NAMESPACE, "__transaction_log_");
Review comment:
are you sure about this '__transaction_log_' ? it is strange that it ends with an underscore character
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12889: [Transaction] Fix transaction system topic create in loop
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12889:
URL: https://github.com/apache/pulsar/pull/12889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on a change in pull request #12889: [Transaction] Fix transaction system topic create in loop
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on a change in pull request #12889:
URL: https://github.com/apache/pulsar/pull/12889#discussion_r753918523
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##########
@@ -67,6 +67,9 @@ public TopicName load(String name) throws Exception {
public static final TopicName TRANSACTION_COORDINATOR_ASSIGN = TopicName.get(TopicDomain.persistent.value(),
NamespaceName.SYSTEM_NAMESPACE, "transaction_coordinator_assign");
+ public static final TopicName TRANSACTION_COORDINATOR_LOG = TopicName.get(TopicDomain.persistent.value(),
+ NamespaceName.SYSTEM_NAMESPACE, "__transaction_log_");
Review comment:
it ends with an underscore character, because there is a coordinator id behind the `__transaction_log_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org