You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/04 18:29:54 UTC

[GitHub] jai1 commented on a change in pull request #1029: Fix MessageRouter hash inconsistent on C++/Java client

jai1 commented on a change in pull request #1029: Fix MessageRouter hash inconsistent on C++/Java client
URL: https://github.com/apache/incubator-pulsar/pull/1029#discussion_r159722967
 
 

 ##########
 File path: pulsar-client-cpp/lib/Murmur3_32.cc
 ##########
 @@ -0,0 +1,108 @@
+/**
 
 Review comment:
   @Licht-T - As per you comment in https://github.com/apache/incubator-pulsar/issues/1017
   > boost::hash uses MurmurHash3
   
   Then why are we reimplementing it and changing the code on C++ side

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services