[jira] [Commented] (TAP5-2344) text assets (including modules and stacks) should assume a utf-8 charset, and incude ;charset=utf-8 in the response content type

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112388#comment-14112388 ] 

ASF subversion and git services commented on TAP5-2344:
-------------------------------------------------------

Commit 000b51e266b2d2b2057b9078f957292999d60f72 in tapestry-5's branch refs/heads/master from [~hlship]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=000b51e ]

TAP5-2344: Asset/module responses are sent without charset


> text assets (including modules and stacks) should assume a utf-8 charset, and incude ;charset=utf-8 in the response content type
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2344
>                 URL: https://issues.apache.org/jira/browse/TAP5-2344
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Jochen Kemnade
>            Assignee: Howard M. Lewis Ship
>              Labels: encoding
>             Fix For: 5.4
>
>
> The Content-Type header sent for asset and module responses does not contain a charset specification. When they are loaded from within a page, browsers seem to assume that they have the same charset as the page, so as long as SymbolConstants.CHARSET is the same as the resource's charset, everything works fine. Changing the symbol value will cause the browser to use that to interpret the resonse and the result will probably be wrong.
> When requesting the module/asset in a separate browser tab, is is interpreted as ISO-5559-1 (HTTP 1.1 default charset). That can be seen when starting the tapestry-core/app1 test app and navigating to http://localhost:8080/tapestry-core/modules/moment.js. All the special characters in the i18n section are broken.



--
This message was sent by Atlassian JIRA
(v6.2#6252)