You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@marvin.apache.org by William Colen <co...@apache.org> on 2018/11/23 17:38:52 UTC
Pull Request: Merge pull request x Rebase and merge
Hi guys,
Looking at the commit history of the project I was wondering if the project
would benefit of avoiding using "Merge pull request" and use "Rebase and
merge" instead.
This will avoid the additional commit related to merging the branch.
What do you think?
William
Re: Pull Request: Merge pull request x Rebase and merge
Posted by Daniel Takabayashi <da...@gmail.com>.
+1
Em sex, 23 de nov de 2018 às 16:25, Luciano Resende <lu...@gmail.com>
escreveu:
> +1, and I had suggested the same before
>
>
> https://lists.apache.org/thread.html/c140b3097ff5e114699e7fbf080032b1ef291a8166dda45809af4d6f@%3Cdev.marvin.apache.org%3E
>
>
> On Fri, Nov 23, 2018 at 18:39 William Colen <co...@apache.org> wrote:
>
> > Hi guys,
> >
> > Looking at the commit history of the project I was wondering if the
> project
> > would benefit of avoiding using "Merge pull request" and use "Rebase and
> > merge" instead.
> > This will avoid the additional commit related to merging the branch.
> >
> > What do you think?
> > William
> >
> --
> Sent from my Mobile device
>
Re: Pull Request: Merge pull request x Rebase and merge
Posted by Luciano Resende <lu...@gmail.com>.
+1, and I had suggested the same before
https://lists.apache.org/thread.html/c140b3097ff5e114699e7fbf080032b1ef291a8166dda45809af4d6f@%3Cdev.marvin.apache.org%3E
On Fri, Nov 23, 2018 at 18:39 William Colen <co...@apache.org> wrote:
> Hi guys,
>
> Looking at the commit history of the project I was wondering if the project
> would benefit of avoiding using "Merge pull request" and use "Rebase and
> merge" instead.
> This will avoid the additional commit related to merging the branch.
>
> What do you think?
> William
>
--
Sent from my Mobile device