[GitHub] [helix] jiajunwang commented on a change in pull request #1605: Fix the PR validate script so the auto label can be applied correctly.

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1605:
URL: https://github.com/apache/helix/pull/1605#discussion_r555319712



##########
File path: .github/workflows/Helix-PR-Premerge-Check.yml
##########
@@ -14,13 +14,62 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - name: Verify All Tasks are Finished
-        uses: venkatsarvesh/pr-tasks-completed-action@v1.0.0
+      - name: Label PR if ready to be merged.
+        uses: actions/github-script@v3
         with:
-          repo-token: "${{ secrets.GITHUB_TOKEN }}"
-      - name: Verify the PR has been approved
-        uses: abinoda/label-when-approved-action@1.0.5
-        env:
-          APPROVALS: "1"
-          ADD_LABEL: "CheckedAndApproved"
-          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
+          github-token: ${{secrets.GITHUB_TOKEN}}
+          script: |
+            const approvalLabel = 'CheckedAndApproved'

Review comment:
       No, what I want is to keep the same behavior as the original script.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org