You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/04 07:59:54 UTC
[GitHub] [incubator-nuttx] spiriou opened a new pull request #1504: libs: add libuv async i/o library
spiriou opened a new pull request #1504:
URL: https://github.com/apache/incubator-nuttx/pull/1504
## Summary
From http://docs.libuv.org/en/v1.x/
"libuv is a multi-platform support library with a focus on asynchronous I/O. It was primarily developed for use by Node.js, but it’s also used by Luvit, Julia, pyuv, and others."
Initial port to NuttX with only basic features enabled (uv_loop_t, uv_poll_t, uv_async_t, uv_timer_t, uv_work_t).
## Impact
None, disabled by default (CONFIG_LIBUV)
## Testing
Follow instructions in libs/libuv/README.txt to setup the library then run "make menuconfig" to enable libuv features.
### Fetch libuv source code
git clone https://github.com/libuv/libuv.git -b v1.38.1 --depth=1 libs/libuv/libuv
### Apply patchs
cd libs/libuv/libuv
git am ../000*.patch
### Import headers in NuttX
cd ../../../
cp -r libs/libuv/libuv/include/* include/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou commented on pull request #1504: libs: add libuv async i/o library
Posted by GitBox <gi...@apache.org>.
spiriou commented on pull request #1504:
URL: https://github.com/apache/incubator-nuttx/pull/1504#issuecomment-668669078
@xiaoxiang781216 It does make sense to move this to app folder. But there is no example of thirdparty library integration in NuttX. What would be the best solution to achieve this ? Can we create a "external" or "thirdparty" folder in apps repo ?
Another solution regarding this contribution is to submit NuttX support in libuv project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1504: libs: add libuv async i/o library
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #1504:
URL: https://github.com/apache/incubator-nuttx/pull/1504#issuecomment-668723869
> @xiaoxiang781216 It does make sense to move this to app folder. But there is no example of thirdparty library integration in NuttX. What would be the best solution to achieve this ?
There are many examples in apps folder(e.g.):
https://github.com/apache/incubator-nuttx-apps/tree/master/graphics/lvgl
The only difference is that whether we put all external projects into the same folder or spread around the code base.
> Can we create a "external" or "thirdparty" folder in apps repo ?
Yes, it could. Since external is used by many out of tree project, we may have to use thirdparty(or 3rdparty).
> Another solution regarding this contribution is to try to submit NuttX support in libuv project.
Yes, it's better to upstream the change to the official project If the patch is general enough. But even the patch is accepted by the upstream, the donwload and Makefile/Kconfig may still be part of NuttX because it is NuttX specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou edited a comment on pull request #1504: libs: add libuv async i/o library
Posted by GitBox <gi...@apache.org>.
spiriou edited a comment on pull request #1504:
URL: https://github.com/apache/incubator-nuttx/pull/1504#issuecomment-668669078
@xiaoxiang781216 It does make sense to move this to app folder. But there is no example of thirdparty library integration in NuttX. What would be the best solution to achieve this ? Can we create a "external" or "thirdparty" folder in apps repo ?
Another solution regarding this contribution is to try to submit NuttX support in libuv project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1504: libs: add libuv async i/o library
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1504:
URL: https://github.com/apache/incubator-nuttx/pull/1504#issuecomment-668723869
> @xiaoxiang781216 It does make sense to move this to app folder. But there is no example of thirdparty library integration in NuttX. What would be the best solution to achieve this ?
There are many examples in apps folder(e.g.):
https://github.com/apache/incubator-nuttx-apps/tree/master/graphics/lvgl
The only difference is that whether we put all external projects into the same folder or spread around the code base.
> Can we create a "external" or "thirdparty" folder in apps repo ?
Yes, it could. Since external is used by many out of tree project, we may have to use thirdparty(or 3rdparty).
> Another solution regarding this contribution is to try to submit NuttX support in libuv project.
Yes, it's better to upstream the change to the official project If the patch is general enough. But even the patch is accepted by the upstream, the donwload and Makefile/Kconfig may still be part of NuttX because it is NuttX specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou closed pull request #1504: libs: add libuv async i/o library
Posted by GitBox <gi...@apache.org>.
spiriou closed pull request #1504:
URL: https://github.com/apache/incubator-nuttx/pull/1504
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1504: libs: add libuv async i/o library
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1504:
URL: https://github.com/apache/incubator-nuttx/pull/1504#issuecomment-668453263
And it's better to auto download the code and apply the patch, like this:
https://github.com/apache/incubator-nuttx/blob/master/openamp/libmetal.defs#L77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1504: libs: add libuv async i/o library
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1504:
URL: https://github.com/apache/incubator-nuttx/pull/1504#issuecomment-668450579
@spiriou it's better to put the 3rd party userspace library to apps folder, here is the related discussion:
https://lists.apache.org/thread.html/rbb2b62b8e7f9fd65fe6404134abec5cd7463f771fac58915a2816283%40%3Cdev.nuttx.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org