You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/23 14:27:26 UTC

[GitHub] [hudi] nsivabalan commented on a change in pull request #3475: [HUDI-1822][RFC-27][WIP] range index support with metadata table

nsivabalan commented on a change in pull request #3475:
URL: https://github.com/apache/hudi/pull/3475#discussion_r734976136



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -671,7 +671,7 @@ public String getBaseFileExtension() {
   }
 
   public boolean requireSortedRecords() {
-    return getBaseFileFormat() == HoodieFileFormat.HFILE;
+    return getBaseFileFormat() == HoodieFileFormat.HFILE || config.requiresSorting();

Review comment:
       @satishkotha : may I know why we need this extra condition. base file is always going to be HFile for metadata table right? Or do we have plans for any other partition where base file will not be Hfile in metadata table? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org