You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dafrista <gi...@git.apache.org> on 2016/10/12 23:21:08 UTC
[GitHub] spark pull request #15455: [SPARK-16827] [Branch-2.0] Avoid reporting spill ...
GitHub user dafrista opened a pull request:
https://github.com/apache/spark/pull/15455
[SPARK-16827] [Branch-2.0] Avoid reporting spill metrics as shuffle metrics
## What changes were proposed in this pull request?
Fix a bug where spill metrics were being reported as shuffle metrics. Eventually these spill metrics should be reported (SPARK-3577), but separate from shuffle metrics. The fix itself basically reverts the line to what it was in 1.6.
## How was this patch tested?
Cherry-picked from master (#15347)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dafrista/spark shuffle-metrics-2.0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15455.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15455
----
commit a53c64c9b0b6ca024e7405b85d3c6f163016964a
Author: Brian Cho <bc...@fb.com>
Date: 2016-10-04T17:47:35Z
[SPARK-16827] Avoid reporting spill metrics as shuffle metrics
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15455: [SPARK-16827] [Branch-2.0] Avoid reporting spill ...
Posted by dafrista <gi...@git.apache.org>.
Github user dafrista closed the pull request at:
https://github.com/apache/spark/pull/15455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15455: [SPARK-16827] [Branch-2.0] Avoid reporting spill metrics...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15455
**[Test build #3336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3336/consoleFull)** for PR 15455 at commit [`a53c64c`](https://github.com/apache/spark/commit/a53c64c9b0b6ca024e7405b85d3c6f163016964a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15455: [SPARK-16827] [Branch-2.0] Avoid reporting spill metrics...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15455
Merging in. Thanks.
Can you also close the pr? GitHub wont' close it automatically because it is not merged into master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15455: [SPARK-16827] [Branch-2.0] Avoid reporting spill metrics...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15455
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15455: [SPARK-16827] [Branch-2.0] Avoid reporting spill metrics...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15455
**[Test build #3336 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3336/consoleFull)** for PR 15455 at commit [`a53c64c`](https://github.com/apache/spark/commit/a53c64c9b0b6ca024e7405b85d3c6f163016964a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org