You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/03 21:49:21 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4243: Add
support for passing headers in pinot client
codecov-io edited a comment on issue #4243: Add support for passing headers in pinot client
URL: https://github.com/apache/incubator-pinot/pull/4243#issuecomment-496501504
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4243?src=pr&el=h1) Report
> Merging [#4243](https://codecov.io/gh/apache/incubator-pinot/pull/4243?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/45a8430bc3d981b44e2d8e242c75480d7dc593e6?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4243?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4243 +/- ##
============================================
- Coverage 67.24% 67.16% -0.08%
Complexity 20 20
============================================
Files 1041 1040 -1
Lines 51514 51544 +30
Branches 7216 7229 +13
============================================
- Hits 34640 34620 -20
- Misses 14506 14553 +47
- Partials 2368 2371 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4243?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/pinot/client/PinotClientTransportFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree#diff-cGlub3QtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jbGllbnQvUGlub3RDbGllbnRUcmFuc3BvcnRGYWN0b3J5LmphdmE=) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...ient/JsonAsyncHttpPinotClientTransportFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree#diff-cGlub3QtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jbGllbnQvSnNvbkFzeW5jSHR0cFBpbm90Q2xpZW50VHJhbnNwb3J0RmFjdG9yeS5qYXZh) | `66.66% <100%> (-33.34%)` | `0 <0> (ø)` | |
| [...inot/client/JsonAsyncHttpPinotClientTransport.java](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree#diff-cGlub3QtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jbGllbnQvSnNvbkFzeW5jSHR0cFBpbm90Q2xpZW50VHJhbnNwb3J0LmphdmE=) | `63.41% <62.5%> (-2.3%)` | `0 <0> (ø)` | |
| [...ava/org/apache/pinot/client/ConnectionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree#diff-cGlub3QtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jbGllbnQvQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `45.45% <75%> (+5.45%)` | `0 <0> (ø)` | :arrow_down: |
| [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `43.33% <0%> (-36.67%)` | `0% <0%> (ø)` | |
| [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `20.28% <0%> (-23.19%)` | `0% <0%> (ø)` | |
| [...ot/core/realtime/stream/PartitionCountFetcher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vUGFydGl0aW9uQ291bnRGZXRjaGVyLmphdmE=) | `54.16% <0%> (-20.84%)` | `0% <0%> (ø)` | |
| [.../pinot/controller/ControllerLeadershipManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9Db250cm9sbGVyTGVhZGVyc2hpcE1hbmFnZXIuamF2YQ==) | `74.41% <0%> (-15.59%)` | `0% <0%> (ø)` | |
| [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `76.39% <0%> (-11.81%)` | `0% <0%> (ø)` | |
| [...a/org/apache/pinot/common/utils/ServiceStatus.java](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvU2VydmljZVN0YXR1cy5qYXZh) | `75% <0%> (-8.96%)` | `0% <0%> (ø)` | |
| ... and [82 more](https://codecov.io/gh/apache/incubator-pinot/pull/4243/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4243?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4243?src=pr&el=footer). Last update [45a8430...cdc1987](https://codecov.io/gh/apache/incubator-pinot/pull/4243?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org