You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/08/29 03:17:29 UTC
[GitHub] [spark] panbingkun opened a new pull request, #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
panbingkun opened a new pull request, #42712:
URL: https://github.com/apache/spark/pull/42712
### What changes were proposed in this pull request?
- The pr is following up pr https://issues.apache.org/jira/browse/SPARK-42642 and https://issues.apache.org/jira/browse/SPARK-44819.
- The pr aims to align example order (Python -> Scala/Java -> R) in all Spark Doc Content and fix some parts bugs of the `structured-streaming-programming-guide.html` page where Python is not the first language, include:
1.quick-start.md
2.structured-streaming-programming-guide.md (Python is not the first language in some code snippets on this page)
3.rdd-programming-guide.md
4.streaming-programming-guide.md
5.sql-getting-started.md
6.README.md
7.index.md
8.ml-pipeline.md
9.sql-programming-guide.md
10._layouts/global.html
### Why are the changes needed?
The order of examples should be consistent (Python -> Scala/Java -> R)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Man
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
URL: https://github.com/apache/spark/pull/42712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42712:
URL: https://github.com/apache/spark/pull/42712#issuecomment-1698532963
Okay, let me first revert the changes outside of `example`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42712:
URL: https://github.com/apache/spark/pull/42712#discussion_r1309020696
##########
docs/index.md:
##########
@@ -34,7 +34,7 @@ source, visit [Building Spark](building-spark.html).
Spark runs on both Windows and UNIX-like systems (e.g. Linux, Mac OS), and it should run on any platform that runs a supported version of Java. This should include JVMs on x86_64 and ARM64. It's easy to run locally on one machine --- all you need is to have `java` installed on your system `PATH`, or the `JAVA_HOME` environment variable pointing to a Java installation.
-Spark runs on Java 8/11/17, Scala 2.12/2.13, Python 3.8+, and R 3.5+.
+Spark runs on Python 3.8+, Scala 2.12/2.13, Java 8/11/17 and R 3.5+.
Review Comment:
-1 for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42712:
URL: https://github.com/apache/spark/pull/42712#issuecomment-1698485120
Yep, I believe so because it's out of scope of `example` (the scope of this PR). We can proceed separately with the community consensus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42712:
URL: https://github.com/apache/spark/pull/42712#issuecomment-1698548604
> Okay, let me first revert the changes outside of `example`.
Thank you, @panbingkun . For the others, it looks good to me and consistent with the AS-IS consensus, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #42712:
URL: https://github.com/apache/spark/pull/42712#discussion_r1309770947
##########
docs/_layouts/global.html:
##########
@@ -71,9 +71,9 @@
<li class="nav-item dropdown">
<a href="#" class="nav-link dropdown-toggle" id="navbarAPIDocs" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">API Docs</a>
<div class="dropdown-menu" aria-labelledby="navbarAPIDocs">
+ <a class="dropdown-item" href="api/python/index.html">Python</a>
Review Comment:
Before:
<img width="221" alt="image" src="https://github.com/apache/spark/assets/15246973/33c9419f-2184-43d8-b1c9-bc4e27a69d9d">
After:
<img width="243" alt="image" src="https://github.com/apache/spark/assets/15246973/a2e774f5-2bfe-4d22-987b-405264802ca3">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42712:
URL: https://github.com/apache/spark/pull/42712#issuecomment-1696712565
cc @allanf-db @HyukjinKwon @allisonwang-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42712:
URL: https://github.com/apache/spark/pull/42712#issuecomment-1698438718
Should probably send an email to the dev mailing list, and see how it goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42712:
URL: https://github.com/apache/spark/pull/42712#issuecomment-1699634715
Merged to master for Apache Spark 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42712:
URL: https://github.com/apache/spark/pull/42712#issuecomment-1696710157
Python is not the first language in some code snippets on `structured-streaming-programming-guide.html` page
1.Before
<img width="925" alt="image" src="https://github.com/apache/spark/assets/15246973/ed2b1b14-7601-4765-98b1-06805b823d38">
2.After
<img width="931" alt="image" src="https://github.com/apache/spark/assets/15246973/442c3ae7-256a-4d18-81fb-9776e6c2ba31">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42712: [SPARK-44997][DOCS] Align example order (Python -> Scala/Java -> R) in all Spark Doc Content
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42712:
URL: https://github.com/apache/spark/pull/42712#discussion_r1309021689
##########
docs/_layouts/global.html:
##########
@@ -128,7 +128,7 @@ <h1 style="max-width: 680px;">Apache Spark - A Unified engine for large-scale da
<div class="row mt-5">
<div class="col-12 col-lg-6 no-gutters">
Apache Spark is a unified analytics engine for large-scale data processing.
- It provides high-level APIs in Java, Scala, Python and R,
+ It provides high-level APIs in Python, Scala, Java and R,
Review Comment:
Also, I'm -1 with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org