[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #253: Daffodil VsCode TDML

["Shanedell (via GitHub)" <gi...@apache.org>]

Shanedell commented on code in PR #253:
URL: https://github.com/apache/daffodil-vscode/pull/253#discussion_r1134777112


##########
package.json:
##########
@@ -35,7 +35,7 @@
     "package-setup": "node -e \"require('./build/scripts/package.ts').setup()\"",
     "package-create": "node -e \"require('./build/scripts/package.ts').create()\"",
     "pretest": "yarn compile && yarn webpack",
-    "test": "node ./out/tests/runTest.js",
+    "test": "node ./out/tests/runTest.js && sbt test",

Review Comment:
   ```suggestion
       "test": "sbt test && node ./out/tests/runTest.js",
   ```
   
   This is the only small thing I had. I believe we want `sbt test` first since some of the node tests depend on the debugger so if it fails an sbt test we should not try to run the node ones.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org