You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/19 17:14:26 UTC
[GitHub] [airflow] potiuk opened a new pull request #11664: Brings back GKEStartPodOperator to google provider.
potiuk opened a new pull request #11664:
URL: https://github.com/apache/airflow/pull/11664
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11664: Brings back GKEStartPodOperator to google provider.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11664:
URL: https://github.com/apache/airflow/pull/11664#issuecomment-712309151
Since "cncf.kubernetes" provider is now ready for release, we can bring back GKEStartPodOperator in the Google Provider.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11664: Brings back GKEStartPodOperator to google provider.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11664:
URL: https://github.com/apache/airflow/pull/11664#issuecomment-712383931
> Can you also remove the following lines?
> https://github.com/apache/airflow/blob/d92711cdac5733859c12205823bd40da6a295e80/provider_packages/refactor_provider_packages.py#L65
>
>
> https://github.com/apache/airflow/blob/d92711cdac5733859c12205823bd40da6a295e80/provider_packages/refactor_provider_packages.py#L49-L55
>
>
> https://github.com/apache/airflow/blob/d92711cdac5733859c12205823bd40da6a295e80/provider_packages/refactor_provider_packages.py#L149-L152
>
>
> https://github.com/apache/airflow/blob/d92711cdac5733859c12205823bd40da6a295e80/provider_packages/refactor_provider_packages.py#L456-L457
>
>
> https://github.com/apache/airflow/blob/d92711cdac5733859c12205823bd40da6a295e80/provider_packages/refactor_provider_packages.py#L502
ahhh. totally forgot about those . Thanks @mik-laj !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11664: Brings back GKEStartPodOperator to google provider.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11664:
URL: https://github.com/apache/airflow/pull/11664#issuecomment-712343641
Can you also remove the following lines?
https://github.com/apache/airflow/blob/d92711cdac5733859c12205823bd40da6a295e80/provider_packages/refactor_provider_packages.py#L65
https://github.com/apache/airflow/blob/d92711cdac5733859c12205823bd40da6a295e80/provider_packages/refactor_provider_packages.py#L49-L55
https://github.com/apache/airflow/blob/d92711cdac5733859c12205823bd40da6a295e80/provider_packages/refactor_provider_packages.py#L149-L152
https://github.com/apache/airflow/blob/d92711cdac5733859c12205823bd40da6a295e80/provider_packages/refactor_provider_packages.py#L456-L457
https://github.com/apache/airflow/blob/d92711cdac5733859c12205823bd40da6a295e80/provider_packages/refactor_provider_packages.py#L502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11664: Brings back GKEStartPodOperator to google provider.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11664:
URL: https://github.com/apache/airflow/pull/11664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org