You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "sungwy (via GitHub)" <gi...@apache.org> on 2026/09/08 19:28:00 UTC

[PR] Enable Issues, with Issue Template [iceberg-verification]

sungwy opened a new pull request, #7:
URL: https://github.com/apache/iceberg-verification/pull/7

   Rendered Issue template:
   
   <img width="803" height="721" alt="Screenshot 2026-09-08 at 2 31 29 PM" src="https://github.com/user-attachments/assets/3c91974f-5e06-40b9-be2a-90f01048560e" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Enable Issues, with Issue Template [iceberg-verification]

Posted by "nssalian (via GitHub)" <gi...@apache.org>.
nssalian commented on code in PR #7:
URL: https://github.com/apache/iceberg-verification/pull/7#discussion_r3962103451


##########
.github/ISSUE_TEMPLATE/issue.yml:
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Issue
+description: Test surfaces, verification tooling, documentation, and repository governance.
+body:
+  - type: markdown
+    attributes:
+      value: |
+        This repository holds cross-language conformance fixtures and the

Review Comment:
   Optional/minor: `apache/iceberg`'s bug template opens with a "possible security vulnerabilities -> stop and contact `security@apache.org`" note, which is a common ASF convention. This repo is test data so the security surface is low and I don't think it's required, but a one-line redirect here in the intro (or a third `contact_links` entry in `config.yml`) would match the other repos.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Enable Issues, with Issue Template [iceberg-verification]

Posted by "nssalian (via GitHub)" <gi...@apache.org>.
nssalian commented on code in PR #7:
URL: https://github.com/apache/iceberg-verification/pull/7#discussion_r3962097635


##########
.github/ISSUE_TEMPLATE/issue.yml:
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Issue

Review Comment:
   The template doesn't set any `labels:`, so filed issues land unlabeled and the `Type` selection only lives in the issue body. The other Iceberg repos' templates auto-apply a label (e.g. `iceberg_bug_report.yml` uses `labels: ["bug"]`), which keeps the issue list filterable. Since the point of the `Type` dropdown is triage, let me know leaving it off the labels intentional? If we want it filterable, a static `labels: [triage]` here (or an Action mapping the dropdown value to a label) would do it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Enable Issues, with Issue Template [iceberg-verification]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #7:
URL: https://github.com/apache/iceberg-verification/pull/7#discussion_r3961609978


##########
.github/ISSUE_TEMPLATE/issue.yml:
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Issue
+description: Test surfaces, verification tooling, documentation, and repository governance.
+body:
+  - type: markdown
+    attributes:
+      value: |
+        This repository holds cross-language conformance fixtures and the
+        guidelines for contributing them.
+
+        The following two discussion topics are explicitly left out of scope of this repository:
+
+        - What the spec requires is discussed and settled on `dev@iceberg.apache.org`.
+        - A divergence in one implementation is fixed in that implementation's
+          repository.
+
+  - type: dropdown
+    id: type

Review Comment:
   GitHub Issue Forms reserve some field identifiers and also commonly use `type` as a conceptual label. To avoid collisions/confusion in automation that reads form fields, prefer a more specific id (e.g., `issue_type`), especially if you plan to add Actions that parse the submitted form.



##########
.github/ISSUE_TEMPLATE/issue.yml:
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Issue

Review Comment:
   The template name `Issue` is very generic and can be ambiguous when a repository later adds additional templates (e.g., Bug report, Feature request). Consider renaming to something more specific to this repo’s purpose (e.g., `Conformance fixtures issue` or `Test fixtures / governance issue`) so users can more quickly choose the right entry in the template picker.



##########
.github/ISSUE_TEMPLATE/issue.yml:
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Issue
+description: Test surfaces, verification tooling, documentation, and repository governance.
+body:
+  - type: markdown
+    attributes:
+      value: |
+        This repository holds cross-language conformance fixtures and the
+        guidelines for contributing them.
+
+        The following two discussion topics are explicitly left out of scope of this repository:
+
+        - What the spec requires is discussed and settled on `dev@iceberg.apache.org`.
+        - A divergence in one implementation is fixed in that implementation's
+          repository.
+
+  - type: dropdown
+    id: type
+    attributes:
+      label: Type
+      description: |
+        - **New test surface**: a spec behavior no subdirectory covers today.
+        - **New cases**: further inputs and expected values under a surface that already exists.
+        - **Fixture correction**: a committed input, expected value, or reference table is wrong.
+        - **Verification tooling**: automation that runs a surface, reports divergence, or generates fixtures.
+        - **Consumption**: wiring this repository into an implementation's CI.
+        - **Documentation**: `README.md`, `CONTRIBUTING.md`, or a surface README.
+        - **Repository governance**: process, ownership, release, or infrastructure.
+      options:
+        - New test surface
+        - New cases in an existing surface
+        - Fixture correction
+        - Verification tooling
+        - Consumption by an implementation
+        - Documentation
+        - Repository governance
+        - Other
+    validations:
+      required: true
+
+  - type: textarea
+    id: description

Review Comment:
   Using `description` as a field `id` can be confusing because the Issue Form itself already has a top-level `description`. Consider renaming the field id to something like `summary` or `details` to reduce ambiguity for future maintainers and for any tooling that parses the YAML.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Enable Issues, with Issue Template [iceberg-verification]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #7:
URL: https://github.com/apache/iceberg-verification/pull/7#discussion_r3971148265


##########
.github/ISSUE_TEMPLATE/02-tooling.yml:
##########
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Tooling
+description: Automation that runs a surface, reports divergence, or generates fixtures.
+labels: ["tooling"]
+body:
+  - type: textarea
+    id: details
+    attributes:
+      label: Description
+      description: >-
+        What the tooling should do, and which surfaces or reference tables it
+        applies to.

Review Comment:
   It feels like there should be more than just the one textarea, but I can't think of what else should be there. I'll leave my comment here but this isn't blocking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Enable Issues, with Issue Template [iceberg-verification]

Posted by "sungwy (via GitHub)" <gi...@apache.org>.
sungwy commented on code in PR #7:
URL: https://github.com/apache/iceberg-verification/pull/7#discussion_r3963347024


##########
.github/ISSUE_TEMPLATE/issue.yml:
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Issue

Review Comment:
   I'm not adopting this nit. This issue template replaces the blank issue template, so we can control the types of issues are created in this repository: https://github.com/apache/iceberg-verification/pull/7/changes#diff-1c0d972ee49103af56fd608a77a28e1eb12f6908f263f0f183d46868fdcd8ea2R18



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Enable Issues, with Issue Template [iceberg-verification]

Posted by "sungwy (via GitHub)" <gi...@apache.org>.
sungwy commented on code in PR #7:
URL: https://github.com/apache/iceberg-verification/pull/7#discussion_r3963338538


##########
.github/ISSUE_TEMPLATE/issue.yml:
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Issue
+description: Test surfaces, verification tooling, documentation, and repository governance.
+body:
+  - type: markdown
+    attributes:
+      value: |
+        This repository holds cross-language conformance fixtures and the

Review Comment:
   I decided to exclude it, because in a repository with just fixtures and runners, I didn't think we'd anticipate security issues being reported.
   
   A typical security reporting pattern is:
   1. Use a source / binary distribution
   2. Identify security vulnerability in the distribution
   3. Report the vulnerability to `security@iceberg.apache.org`
   
   It sounds odd to me to expect that type of reporting in this repository. What do you think? @rambleraptor @nssalian 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Enable Issues, with Issue Template [iceberg-verification]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on code in PR #7:
URL: https://github.com/apache/iceberg-verification/pull/7#discussion_r3962628783


##########
.github/ISSUE_TEMPLATE/issue.yml:
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Issue
+description: Test surfaces, verification tooling, documentation, and repository governance.
+body:
+  - type: markdown
+    attributes:
+      value: |
+        This repository holds cross-language conformance fixtures and the

Review Comment:
   I'd actually bump this up as more major.
   
   I can see a world where somebody has created a test fixture that replicates a security vulnerability as a way to ensure that all of the libraries have this fixed. This fixture shouldn't be the first step in reporting, but the last step after all of the libraries have been fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Enable Issues, with Issue Template [iceberg-verification]

Posted by "sungwy (via GitHub)" <gi...@apache.org>.
sungwy merged PR #7:
URL: https://github.com/apache/iceberg-verification/pull/7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Enable Issues, with Issue Template [iceberg-verification]

Posted by "sungwy (via GitHub)" <gi...@apache.org>.
sungwy commented on code in PR #7:
URL: https://github.com/apache/iceberg-verification/pull/7#discussion_r3963325531


##########
.github/ISSUE_TEMPLATE/issue.yml:
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Issue

Review Comment:
   nice suggestion 👍 - let me check how this works



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Enable Issues, with Issue Template [iceberg-verification]

Posted by "sungwy (via GitHub)" <gi...@apache.org>.
sungwy commented on PR #7:
URL: https://github.com/apache/iceberg-verification/pull/7#issuecomment-5611049292

   Thanks for the reviews @zeroshade and @nssalian !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org