[GitHub] [helix] narendly commented on issue #601: Add new constructors and close() to Helix API

[GitBox <gi...@apache.org>]

narendly commented on issue #601: Add new constructors and close() to Helix API
URL: https://github.com/apache/helix/pull/601#issuecomment-553561810
 
 
   > The strange flag `usedExternalZkClient` will need to be added to each and every accessor that wraps the ZkClient by your proposal, right?
   > My idea is to leave a clean implementation for all the `close` method in those accessors, create a boolean field inside ZkClient `isShared` something. As long as it's created by SharedZkClientFactory it will be true, and the close method will respect the boolean to perform the actual close action.
   
   It's more about whether ZkClient we're using is external or not. Whether it's a SharedZkClient or not has little to do with this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org