You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/06 06:58:12 UTC

[GitHub] [airflow] Taragolis commented on pull request #28139: Migrate amazon provider sensor tests from `unittests` to `pytest`

Taragolis commented on PR #28139:
URL: https://github.com/apache/airflow/pull/28139#issuecomment-1338874407

   Nice 👍 
   
   Could you also replace `parameterized.expand` by [pytest.mark.parametrize](https://docs.pytest.org/en/6.2.x/parametrize.html) it is more powerful, [some example](https://github.com/Taragolis/airflow/blob/6ecb2f8cc4a949284e3143796ee5c4097bde1c25/tests/providers/amazon/aws/sensors/test_s3_keys_unchanged.py#L78-L100). You could find all modules where **parameterized.expand** uses by run `grep -rl 'parameterized' ./tests/providers/amazon/aws/sensors | uniq`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org