You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@edgent.apache.org by dl...@apache.org on 2017/02/02 16:52:30 UTC
[1/2] incubator-edgent git commit: [Edgent-374] log warnings on
controlCmd lookup failures
Repository: incubator-edgent
Updated Branches:
refs/heads/master 2eb5897da -> 1e9a9066d
[Edgent-374] log warnings on controlCmd lookup failures
Project: http://git-wip-us.apache.org/repos/asf/incubator-edgent/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-edgent/commit/20eb829b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-edgent/tree/20eb829b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-edgent/diff/20eb829b
Branch: refs/heads/master
Commit: 20eb829bbd537a2dece94b88586b0f4a28b2aa9d
Parents: 66b6861
Author: Dale LaBossiere <dl...@us.ibm.com>
Authored: Wed Feb 1 14:59:41 2017 -0500
Committer: Dale LaBossiere <dl...@us.ibm.com>
Committed: Wed Feb 1 14:59:41 2017 -0500
----------------------------------------------------------------------
.../edgent/runtime/jsoncontrol/JsonControlService.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-edgent/blob/20eb829b/runtime/jsoncontrol/src/main/java/org/apache/edgent/runtime/jsoncontrol/JsonControlService.java
----------------------------------------------------------------------
diff --git a/runtime/jsoncontrol/src/main/java/org/apache/edgent/runtime/jsoncontrol/JsonControlService.java b/runtime/jsoncontrol/src/main/java/org/apache/edgent/runtime/jsoncontrol/JsonControlService.java
index 983287d..780e173 100644
--- a/runtime/jsoncontrol/src/main/java/org/apache/edgent/runtime/jsoncontrol/JsonControlService.java
+++ b/runtime/jsoncontrol/src/main/java/org/apache/edgent/runtime/jsoncontrol/JsonControlService.java
@@ -156,8 +156,10 @@ public class JsonControlService implements ControlService {
mbean = mbeans.get(controlId);
}
- if (mbean == null)
+ if (mbean == null) {
+ logger.warn("Unable to find mbean for control id: {}", controlId);
return new JsonPrimitive(Boolean.FALSE);
+ }
String methodName = request.get(OP_KEY).getAsString();
@@ -173,8 +175,10 @@ public class JsonControlService implements ControlService {
Method method = findMethod(mbean.getControlInterface(), methodName, argumentCount);
- if (method == null)
+ if (method == null) {
+ logger.warn("Unable to find method \"{}\" with {} args in {}", methodName, argumentCount, mbean.getControlInterface().getName());
return new JsonPrimitive(Boolean.FALSE);
+ }
logger.trace("Execute operation - control id: {} method: {}", controlId, methodName);
[2/2] incubator-edgent git commit: Merge pull request #279
Posted by dl...@apache.org.
Merge pull request #279
This closes #279
Project: http://git-wip-us.apache.org/repos/asf/incubator-edgent/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-edgent/commit/1e9a9066
Tree: http://git-wip-us.apache.org/repos/asf/incubator-edgent/tree/1e9a9066
Diff: http://git-wip-us.apache.org/repos/asf/incubator-edgent/diff/1e9a9066
Branch: refs/heads/master
Commit: 1e9a9066d924403eab8e21ec5bbd567fd68b1509
Parents: 2eb5897 20eb829
Author: Dale LaBossiere <dl...@us.ibm.com>
Authored: Thu Feb 2 11:52:24 2017 -0500
Committer: Dale LaBossiere <dl...@us.ibm.com>
Committed: Thu Feb 2 11:52:24 2017 -0500
----------------------------------------------------------------------
.../edgent/runtime/jsoncontrol/JsonControlService.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------