You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/15 11:42:41 UTC
[GitHub] [superset] codecov[bot] commented on pull request #13576: feat(filter-set): Filter set edge cases
codecov[bot] commented on pull request #13576:
URL: https://github.com/apache/superset/pull/13576#issuecomment-799352665
# [Codecov](https://codecov.io/gh/apache/superset/pull/13576?src=pr&el=h1) Report
> Merging [#13576](https://codecov.io/gh/apache/superset/pull/13576?src=pr&el=desc) (2d061ef) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `4.52%`.
> The diff coverage is `32.52%`.
[](https://codecov.io/gh/apache/superset/pull/13576?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13576 +/- ##
==========================================
- Coverage 77.53% 73.01% -4.53%
==========================================
Files 904 608 -296
Lines 45986 21637 -24349
Branches 5552 5725 +173
==========================================
- Hits 35657 15799 -19858
+ Misses 10195 5702 -4493
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.56% <20.65%> (-0.64%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.04% <30.18%> (-0.34%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13576?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [339 more](https://codecov.io/gh/apache/superset/pull/13576/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13576?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13576?src=pr&el=footer). Last update [5fca19d...6c72bbb](https://codecov.io/gh/apache/superset/pull/13576?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org