You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/25 01:52:54 UTC

[GitHub] [incubator-pinot] kishoreg commented on issue #4361: Fix NPE when there is no aggregation results in prettyPrintResponse

kishoreg commented on issue #4361: Fix NPE when there is no aggregation results in prettyPrintResponse
URL: https://github.com/apache/incubator-pinot/pull/4361#issuecomment-505245244
 
 
   this is not the right fix. It just masking NPE. The real problem is in the following lines
   ```    
   printStatus(Color.CYAN, "***** Waiting for 5 seconds for the server to fetch the assigned segment *****");   
   Thread.sleep(5000);
   ```
   Similar to what we have in integration tests, we need to wait until the segments are loaded and select count(*) returns the right number. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org