[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #201: [YUNIKORN-390] Panic in placement rule evaluation

[GitBox <gi...@apache.org>]

adamantal commented on a change in pull request #201:
URL: https://github.com/apache/incubator-yunikorn-core/pull/201#discussion_r481027661



##########
File path: pkg/scheduler/placement/tag_rule_test.go
##########
@@ -144,3 +144,112 @@ partitions:
 		t.Errorf("tag rule with parent queue incorrect queue '%s', error %v", queue, err)
 	}
 }
+
+// Create the structure for the parent rule tests
+// shared by a number of rule tests
+const confParentChild = `

Review comment:
       I don't see why it has been put to the tag rule. IDEs provide quick jump to the definition, but it's a bit counterintuitive. I think this can be moved to `rule_test.go` or `test_rule.go`, or even a helper go file can be created for this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org