[GitHub] [netbeans] sdedic commented on a diff in pull request #5224: Removed double null check with instance operator

[GitBox <gi...@apache.org>]

sdedic commented on code in PR #5224:
URL: https://github.com/apache/netbeans/pull/5224#discussion_r1063827922


##########
platform/openide.explorer/src/org/openide/explorer/propertysheet/PropertyDialogManager.java:
##########
@@ -120,7 +120,7 @@ public PropertyDialogManager(
         if (env != null) {
             Object helpID = env.getFeatureDescriptor().getValue(ExPropertyEditor.PROPERTY_HELP_ID);
 
-            if ((helpID != null) && helpID instanceof String && (component != null) && component instanceof JComponent) {
+            if (helpID instanceof String && (component != null) && component instanceof JComponent) {

Review Comment:
   Yet another != null && instanceof :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists