You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/11 17:05:43 UTC
[GitHub] [airflow] dstandish opened a new pull request, #22916: Clarify breeze install message re pipx vs `./breeze`
dstandish opened a new pull request, #22916:
URL: https://github.com/apache/airflow/pull/22916
The first sentence, "When you have multiple copies of Airflow" was momentarily confusing. It wasn't obvious that the context was "to use pipx or ./breeze". I try to make that a little clearer here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish closed pull request #22916: Clarify breeze install message re pipx vs `./breeze`
Posted by GitBox <gi...@apache.org>.
dstandish closed pull request #22916: Clarify breeze install message re pipx vs `./breeze`
URL: https://github.com/apache/airflow/pull/22916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #22916: Clarify breeze install message re pipx vs `./breeze`
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #22916:
URL: https://github.com/apache/airflow/pull/22916#issuecomment-1095567202
haha yeah thought it was bit weird but did not give it much thought
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22916: Clarify breeze install message re pipx vs `./breeze`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22916:
URL: https://github.com/apache/airflow/pull/22916#issuecomment-1095431205
I completely missed updatinng those instructions after making this decision :blush:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22916: Clarify breeze install message re pipx vs `./breeze`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22916:
URL: https://github.com/apache/airflow/pull/22916#issuecomment-1095429206
(and yeah we MUST update the instructions - they are wrong currently).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22916: Clarify breeze install message re pipx vs `./breeze`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22916:
URL: https://github.com/apache/airflow/pull/22916#issuecomment-1095425532
Hmmm. That's not really correct. The new `breeze` actually REQUIRES `pipx` . This is the only supported method of installation. The `./breeze` script is merely wrapper around it when you look closely.
Maybe the message should be clearer but it's not either-or. The `./breeze` script is temporary to ease people to migrate but we will remove it eventually.
We thought and tried quite some time about whether to support two ways of running `breeze` but due to autocomplete requiring installing the `airflow-breeze` as package AND having `breeze` on the path - we chose `pipx` as the only way to install the new breeze.
This has been captured in ADR 10 here with the detailed reasoning and invalidating earlier ADR 3 where we did not decide about the way of installation until we learn more: https://github.com/apache/airflow/blob/main/dev/breeze/doc/adr/0010-use-pipx-to-install-breeze.md (includes context and consequences).
If you do not use `pipx`, there are few consequnces. Most notable is that "self-upgrade" command will not work. It assumes breeze is installed with `pipx` and will attempt to use `pipx` to upgrade it to get latest dependencies installed. It even allows you to reinstall `breeze` from a different source tree (because it might be that you have version 2.3 and main where `main` breeze will not work on `2.3` branch. Breeze warns the user if you try to use it from a wrong source tree and offers you to reinstall it.
This all is strongly rooted with the assumption that breeze is installed with `pipx`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22916: Clarify breeze install message re pipx vs `./breeze`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22916:
URL: https://github.com/apache/airflow/pull/22916#issuecomment-1095556477
Actuallly - this message should not be there at all :). It's chicken-egg. You won't see it until Breeze is installed, but if you have it installed, you don;t need it any more :) #22923 removes it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #22916: Clarify breeze install message re pipx vs `./breeze`
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #22916:
URL: https://github.com/apache/airflow/pull/22916#issuecomment-1095461058
Ok sounds good, was just making assumptions
Will close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org