You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "prasanna-marathe (via GitHub)" <gi...@apache.org> on 2025/11/10 16:37:39 UTC
[PR] Enable IBM Power support for artemis-elasticsearch example [camel-quarkus-examples]
prasanna-marathe opened a new pull request, #429:
URL: https://github.com/apache/camel-quarkus-examples/pull/429
artemis-elasticsearch example is newly added in camel-quarkus-examples repo, Need to add IBM Power supported images in artemis-elasticsearch example so that in can be tested on IBM power. Code is tested on both IBM Power and x86 platform
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable IBM Power support for artemis-elasticsearch example [camel-quarkus-examples]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #429:
URL: https://github.com/apache/camel-quarkus-examples/pull/429#discussion_r2513512826
##########
artemis-elasticsearch/src/test/java/org/acme/resource/CustomPahoTestResource.java:
##########
@@ -20,18 +20,26 @@
import java.util.Map;
import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
+import org.apache.commons.lang3.SystemUtils;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.utility.DockerImageName;
public class CustomPahoTestResource implements QuarkusTestResourceLifecycleManager {
- private static final String IMAGE_NAME = "quay.io/artemiscloud/activemq-artemis-broker:1.0.26";
+ private static String IMAGE_NAME;
private static final String AMQ_USER = "admin";
private static final String AMQ_PASSWORD = "admin";
private static final String AMQ_EXTRA_ARGS = "--relax-jolokia --no-autotune --mapped --no-fsync --java-options=-Dbrokerconfig.maxDiskUsage=-1";
private GenericContainer<?> container;
+
@Override
public Map<String, String> start() {
+ if ("ppc64le".equals(SystemUtils.OS_ARCH))
+ IMAGE_NAME = "icr.io/ppc64le-oss/activemq-artemis-broker-ppc64le:2.0.2";
+ else
+ IMAGE_NAME = "quay.io/artemiscloud/activemq-artemis-broker:1.0.26";
+
+
container = new GenericContainer<>(DockerImageName.parse(IMAGE_NAME))
Review Comment:
```suggestion
private static final String AMQ_USER = "admin";
private static final String AMQ_PASSWORD = "admin";
private static final String AMQ_EXTRA_ARGS = "--relax-jolokia --no-autotune --mapped --no-fsync --java-options=-Dbrokerconfig.maxDiskUsage=-1";
private GenericContainer<?> container;
@Override
public Map<String, String> start() {
String imageName = "quay.io/artemiscloud/activemq-artemis-broker:1.0.26";
if ("ppc64le".equals(SystemUtils.OS_ARCH)) {
imageName = "icr.io/ppc64le-oss/activemq-artemis-broker-ppc64le:2.0.2";
}
container = new GenericContainer<>(DockerImageName.parse(imageName))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable IBM Power support for artemis-elasticsearch example [camel-quarkus-examples]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #429:
URL: https://github.com/apache/camel-quarkus-examples/pull/429#discussion_r2513503490
##########
artemis-elasticsearch/src/test/java/org/acme/resource/ElasticSearchTestResource.java:
##########
@@ -22,22 +22,27 @@
import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.apache.commons.lang3.SystemUtils;
import org.testcontainers.containers.wait.strategy.Wait;
import org.testcontainers.elasticsearch.ElasticsearchContainer;
import org.testcontainers.utility.DockerImageName;
public class ElasticSearchTestResource implements QuarkusTestResourceLifecycleManager {
private static final Logger LOG = LoggerFactory.getLogger(ElasticSearchTestResource.class);
- private static final String IMAGE_NAME = "mirror.gcr.io/elastic/elasticsearch:8.13.2";
+ private static String IMAGE_NAME = "mirror.gcr.io/elastic/elasticsearch:8.13.2";
Review Comment:
As per the suggested change in the previous comment. We don't need a static field for this. It can be a local variable defined within `start()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable IBM Power support for artemis-elasticsearch example [camel-quarkus-examples]
Posted by "prasanna-marathe (via GitHub)" <gi...@apache.org>.
prasanna-marathe commented on PR #429:
URL: https://github.com/apache/camel-quarkus-examples/pull/429#issuecomment-3532425466
It is done. Thanks @jamesnetherton for help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable IBM Power support for artemis-elasticsearch example [camel-quarkus-examples]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #429:
URL: https://github.com/apache/camel-quarkus-examples/pull/429#issuecomment-3532315500
@prasanna-marathe the import order need fixing up.
If you run `mvn clean install -DskipTests` within the `artemis-elasticsearch` directory, it should fix it for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable IBM Power support for artemis-elasticsearch example [camel-quarkus-examples]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #429:
URL: https://github.com/apache/camel-quarkus-examples/pull/429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable IBM Power support for artemis-elasticsearch example [camel-quarkus-examples]
Posted by "prasanna-marathe (via GitHub)" <gi...@apache.org>.
prasanna-marathe commented on code in PR #429:
URL: https://github.com/apache/camel-quarkus-examples/pull/429#discussion_r2526904373
##########
artemis-elasticsearch/src/test/java/org/acme/resource/ElasticSearchTestResource.java:
##########
@@ -22,22 +22,27 @@
import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.apache.commons.lang3.SystemUtils;
import org.testcontainers.containers.wait.strategy.Wait;
import org.testcontainers.elasticsearch.ElasticsearchContainer;
import org.testcontainers.utility.DockerImageName;
public class ElasticSearchTestResource implements QuarkusTestResourceLifecycleManager {
private static final Logger LOG = LoggerFactory.getLogger(ElasticSearchTestResource.class);
- private static final String IMAGE_NAME = "mirror.gcr.io/elastic/elasticsearch:8.13.2";
+ private static String IMAGE_NAME = "mirror.gcr.io/elastic/elasticsearch:8.13.2";
Review Comment:
updated code
##########
artemis-elasticsearch/src/test/java/org/acme/resource/CustomPahoTestResource.java:
##########
@@ -20,18 +20,26 @@
import java.util.Map;
import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
+import org.apache.commons.lang3.SystemUtils;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.utility.DockerImageName;
public class CustomPahoTestResource implements QuarkusTestResourceLifecycleManager {
- private static final String IMAGE_NAME = "quay.io/artemiscloud/activemq-artemis-broker:1.0.26";
+ private static String IMAGE_NAME;
private static final String AMQ_USER = "admin";
private static final String AMQ_PASSWORD = "admin";
private static final String AMQ_EXTRA_ARGS = "--relax-jolokia --no-autotune --mapped --no-fsync --java-options=-Dbrokerconfig.maxDiskUsage=-1";
private GenericContainer<?> container;
+
@Override
public Map<String, String> start() {
+ if ("ppc64le".equals(SystemUtils.OS_ARCH))
+ IMAGE_NAME = "icr.io/ppc64le-oss/activemq-artemis-broker-ppc64le:2.0.2";
+ else
+ IMAGE_NAME = "quay.io/artemiscloud/activemq-artemis-broker:1.0.26";
+
+
container = new GenericContainer<>(DockerImageName.parse(IMAGE_NAME))
Review Comment:
updated code as per comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org