You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2020/03/02 05:41:26 UTC

Re: Review Request 72174: ATLAS-3600 :- Some System Attribute of Entity filter doesn't work

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72174/
-----------------------------------------------------------

(Updated March 2, 2020, 5:41 a.m.)


Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Summary (updated)
-----------------

ATLAS-3600 :- Some System Attribute of Entity filter doesn't work


Bugs: ATLAS-3600
    https://issues.apache.org/jira/browse/ATLAS-3600


Repository: atlas


Description
-------

System Attributes does not support following 4 search ,

classification search
Propogated Classification Search
User-Defined Attributes 
Labels


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java c74cf5122 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 356363db0 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633 


Diff: https://reviews.apache.org/r/72174/diff/1/


Testing
-------

Tested all above 4 system attributes manually.


Thanks,

Pinal Shah


Re: Review Request 72174: ATLAS-3600 :- Some System Attribute of Entity filter doesn't work

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72174/#review219711
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On March 2, 2020, 5:41 a.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72174/
> -----------------------------------------------------------
> 
> (Updated March 2, 2020, 5:41 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3600
>     https://issues.apache.org/jira/browse/ATLAS-3600
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> System Attributes does not support following 4 search ,
> 
> classification search
> Propogated Classification Search
> User-Defined Attributes 
> Labels
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java c74cf5122 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 356363db0 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633 
> 
> 
> Diff: https://reviews.apache.org/r/72174/diff/1/
> 
> 
> Testing
> -------
> 
> Tested all above 4 system attributes manually.
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>


Re: Review Request 72174: ATLAS-3600 :- Some System Attribute of Entity filter doesn't work

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72174/#review219761
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On March 2, 2020, 12:14 p.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72174/
> -----------------------------------------------------------
> 
> (Updated March 2, 2020, 12:14 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3600
>     https://issues.apache.org/jira/browse/ATLAS-3600
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> System Attributes does not support following 4 search ,
> 
> classification search
> Propogated Classification Search
> User-Defined Attributes 
> Labels
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java c74cf5122 
>   repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 8f531876b 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 356363db0 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633 
> 
> 
> Diff: https://reviews.apache.org/r/72174/diff/2/
> 
> 
> Testing
> -------
> 
> Tested all above 4 system attributes manually.
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>


Re: Review Request 72174: ATLAS-3600 :- Some System Attribute of Entity filter doesn't work

Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72174/
-----------------------------------------------------------

(Updated March 2, 2020, 12:14 p.m.)


Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

added one usecase, when in graphquery, filter with not_contains is not added


Bugs: ATLAS-3600
    https://issues.apache.org/jira/browse/ATLAS-3600


Repository: atlas


Description
-------

System Attributes does not support following 4 search ,

classification search
Propogated Classification Search
User-Defined Attributes 
Labels


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java c74cf5122 
  repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 8f531876b 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 356363db0 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633 


Diff: https://reviews.apache.org/r/72174/diff/2/

Changes: https://reviews.apache.org/r/72174/diff/1-2/


Testing
-------

Tested all above 4 system attributes manually.


Thanks,

Pinal Shah