You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Thomas Neidhart (JIRA)" <ji...@apache.org> on 2013/01/18 16:20:12 UTC

[jira] [Updated] (LOGGING-144) LogFactory/LogFactoryImpl ingore Throwable

     [ https://issues.apache.org/jira/browse/LOGGING-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Neidhart updated LOGGING-144:
------------------------------------

    Attachment: LOGGING-144.patch

First bunch of changes, please review.

Missing is the catch in LogFactoryImpl.createLogFromClass which calls then handleFlawedDiscovery.
                
> LogFactory/LogFactoryImpl ingore Throwable
> ------------------------------------------
>
>                 Key: LOGGING-144
>                 URL: https://issues.apache.org/jira/browse/LOGGING-144
>             Project: Commons Logging
>          Issue Type: Bug
>    Affects Versions: 1.1.1
>            Reporter: Sebb
>         Attachments: LOGGING-144.patch
>
>
> The code in LogFactory/LogFactoryImpl catches and ignores Throwable in several places.
> This is a bad idea, as some Throwables (e.g. ThreadDeath) should never be ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira