You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/06/05 00:51:43 UTC
Review Request 22250: A one-off fix for MESOS-1456: it ties the lifetime of
metrics in SchedulerProcess to its runstate and not lifetime.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22250/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Dominic Hamon.
Bugs: MESOS-1456
https://issues.apache.org/jira/browse/MESOS-1456
Repository: mesos-git
Description
-------
This fix is just for SchedularProcess. I'll let Dominic decide whether/how to generalize it for all processes and metric types.
Diffs
-----
src/sched/sched.cpp b27222e806387ea18ef37584e2626974c665fa0b
src/tests/scheduler_tests.cpp 5cc6b264e2c3de241ebd001bf22828423c03a51e
Diff: https://reviews.apache.org/r/22250/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 22250: A one-off fix for MESOS-1456: it ties the lifetime
of metrics in SchedulerProcess to its runstate and not lifetime.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22250/#review44771
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On June 4, 2014, 3:51 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22250/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 3:51 p.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Bugs: MESOS-1456
> https://issues.apache.org/jira/browse/MESOS-1456
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This fix is just for SchedularProcess. I'll let Dominic decide whether/how to generalize it for all processes and metric types.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp b27222e806387ea18ef37584e2626974c665fa0b
> src/tests/scheduler_tests.cpp 5cc6b264e2c3de241ebd001bf22828423c03a51e
>
> Diff: https://reviews.apache.org/r/22250/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 22250: A one-off fix for MESOS-1456: it ties the lifetime
of metrics in SchedulerProcess to its runstate and not lifetime.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22250/#review44879
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22250]
All tests passed.
- Mesos ReviewBot
On June 4, 2014, 10:51 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22250/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 10:51 p.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Bugs: MESOS-1456
> https://issues.apache.org/jira/browse/MESOS-1456
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This fix is just for SchedularProcess. I'll let Dominic decide whether/how to generalize it for all processes and metric types.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp b27222e806387ea18ef37584e2626974c665fa0b
> src/tests/scheduler_tests.cpp 5cc6b264e2c3de241ebd001bf22828423c03a51e
>
> Diff: https://reviews.apache.org/r/22250/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 22250: A one-off fix for MESOS-1456: it ties the lifetime
of metrics in SchedulerProcess to its runstate and not lifetime.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22250/#review44786
-----------------------------------------------------------
Dominic and I went over this together and it seems this does not fix the issue fully.
I'm curious if it makes sense to update the semantics around invalid dispatches, see my comment here for more explanation:
https://issues.apache.org/jira/browse/MESOS-1456?focusedCommentId=14018375&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14018375
- Ben Mahler
On June 4, 2014, 10:51 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22250/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 10:51 p.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Bugs: MESOS-1456
> https://issues.apache.org/jira/browse/MESOS-1456
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This fix is just for SchedularProcess. I'll let Dominic decide whether/how to generalize it for all processes and metric types.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp b27222e806387ea18ef37584e2626974c665fa0b
> src/tests/scheduler_tests.cpp 5cc6b264e2c3de241ebd001bf22828423c03a51e
>
> Diff: https://reviews.apache.org/r/22250/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>