You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/10/17 19:51:53 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request, #4259: ARTEMIS-4049 user add fails w/space in broker path
jbertram opened a new pull request, #4259:
URL: https://github.com/apache/activemq-artemis/pull/4259
This problem was originally discovered on Windows, but the problem occurs on *nix as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #4259: ARTEMIS-4049 user add fails w/space in broker path
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4259: ARTEMIS-4049 user add fails w/space in broker path
URL: https://github.com/apache/activemq-artemis/pull/4259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4259: ARTEMIS-4049 user add fails w/space in broker path
Posted by GitBox <gi...@apache.org>.
jbertram commented on code in PR #4259:
URL: https://github.com/apache/activemq-artemis/pull/4259#discussion_r998436204
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java:
##########
@@ -4535,8 +4537,8 @@ private PropertiesLoginModuleConfigurator getPropertiesLoginModuleConfigurator()
if (configurationUrl == null) {
throw ActiveMQMessageBundle.BUNDLE.failedToLocateConfigURL();
}
- String path = configurationUrl.getPath();
- return new PropertiesLoginModuleConfigurator(getSecurityDomain(), path.substring(0, path.lastIndexOf("/")));
+ String path = Paths.get(configurationUrl.toURI()).toString();
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4259: ARTEMIS-4049 user add fails w/space in broker path
Posted by GitBox <gi...@apache.org>.
gemmellr commented on code in PR #4259:
URL: https://github.com/apache/activemq-artemis/pull/4259#discussion_r997899160
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java:
##########
@@ -4535,8 +4537,8 @@ private PropertiesLoginModuleConfigurator getPropertiesLoginModuleConfigurator()
if (configurationUrl == null) {
throw ActiveMQMessageBundle.BUNDLE.failedToLocateConfigURL();
}
- String path = configurationUrl.getPath();
- return new PropertiesLoginModuleConfigurator(getSecurityDomain(), path.substring(0, path.lastIndexOf("/")));
+ String path = Paths.get(configurationUrl.toURI()).toString();
Review Comment:
The doc for Paths indicates to use Path.of(..) instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org