You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/10/23 11:32:43 UTC
[GitHub] [httpcomponents-core] anuragagarwal561994 commented on issue #153:
Fixes HTTPCORE-609 by cancelling the key assigned to completed request
anuragagarwal561994 commented on issue #153: Fixes HTTPCORE-609 by cancelling the key assigned to completed request
URL: https://github.com/apache/httpcomponents-core/pull/153#issuecomment-545400258
@garydgregory I don't think it should create any issues, this is because key.cancel even on multiple calls doesn't produce an error. Check https://docs.oracle.com/javase/7/docs/api/java/nio/channels/SelectionKey.html#cancel()
The idea is that for a cancelled request if any key is assigned by any workflow it should be cancelled as well for maintaining consistent state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org