You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/02/26 10:21:02 UTC
[GitHub] sijie commented on a change in pull request #1966: Fix unable
download twitter dependencies
sijie commented on a change in pull request #1966: Fix unable download twitter dependencies
URL: https://github.com/apache/bookkeeper/pull/1966#discussion_r260216416
##########
File path: bookkeeper-stats-providers/pom.xml
##########
@@ -26,10 +26,25 @@
<packaging>pom</packaging>
<name>Apache BookKeeper :: Stats Providers</name>
<modules>
- <module>twitter-finagle-provider</module>
- <module>twitter-science-provider</module>
- <module>twitter-ostrich-provider</module>
<module>codahale-metrics-provider</module>
<module>prometheus-metrics-provider</module>
</modules>
+
+ <profiles>
+ <profile>
+ <id>twitter</id>
+ <activation>
+ <property>
+ <name>twitter</name>
+ </property>
+ </activation>
+ <modules>
+ <!-- enable building table service -->
Review comment:
@zymap can you change the comment? for example:
```suggestion
<!-- only building twitter stats providers when `-Dtwitter` is provided -->
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services