You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Feng Guangyuan (Code Review)" <ge...@cloudera.org> on 2016/06/08 08:29:20 UTC
[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes
Feng Guangyuan has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3335
Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes
......................................................................
IMPALA-3153: Incorrect behaviour around slash escaping single quotes
This patch adds a sub process, inserting into a slash before a single
quote in a String, to solve this issue that a String is cut off from
the single quote.
Now for the string expressions, containing "'" or "\'", are analysised
well.
Change-Id: I002f75f3330ee319d82213331a5a046ecf198189
---
M fe/src/main/java/com/cloudera/impala/analysis/StringLiteral.java
1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/35/3335/1
--
To view, visit http://gerrit.cloudera.org:8080/3335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I002f75f3330ee319d82213331a5a046ecf198189
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>
[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes
Posted by "Feng Guangyuan (Code Review)" <ge...@cloudera.org>.
Feng Guangyuan has posted comments on this change.
Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes
......................................................................
Patch Set 2:
Hi, Jim.
If it's proper to add a new query test file into
{IMPALA_HOME}/testdata/workloads/tpch/queries/,
like 'tpch-q1.test'?
Thanks. :)
--
To view, visit http://gerrit.cloudera.org:8080/3335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I002f75f3330ee319d82213331a5a046ecf198189
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes
Posted by "Feng Guangyuan (Code Review)" <ge...@cloudera.org>.
Feng Guangyuan has uploaded a new patch set (#2).
Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes
......................................................................
IMPALA-3153: Incorrect behaviour around slash escaping single quotes
This patch adds a sub process, inserting into a slash before a single
quote in a String, to solve this issue that a String is cut off from
the single quote.
Now for the string expressions, containing "'" or "\'", are analysised
well.
Change-Id: I002f75f3330ee319d82213331a5a046ecf198189
---
M fe/src/main/java/com/cloudera/impala/analysis/StringLiteral.java
1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/35/3335/2
--
To view, visit http://gerrit.cloudera.org:8080/3335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I002f75f3330ee319d82213331a5a046ecf198189
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has abandoned this change.
Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes
......................................................................
Abandoned
This change is small enough that it should be re-sent on the new gerrit project Impala-ASF. See https://cwiki.apache.org/confluence/display/IMPALA/How+to+switch+to+Apache-hosted+git
--
To view, visit http://gerrit.cloudera.org:8080/3335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I002f75f3330ee319d82213331a5a046ecf198189
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes
......................................................................
Patch Set 1:
Please add tests.
Also, as a reminder, the gerrit "Impala" project is now deprecated. To lear now to switch, read
http://mail-archives.apache.org/mod_mbox/incubator-impala-dev/201607.mbox/%3CCAC-pSX2sHyqsoxGCCKrqmQbo-jjWdP6CMGoTU_1snuQVkDVg_w@mail.gmail.com%3E
To make sure you receive all messages that look like this, subscribe to
http://mail-archives.apache.org/mod_mbox/incubator-impala-dev/
--
To view, visit http://gerrit.cloudera.org:8080/3335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I002f75f3330ee319d82213331a5a046ecf198189
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes
......................................................................
Patch Set 2:
> Hi, Jim.
> If it's proper to add a new query test file into
> {IMPALA_HOME}/testdata/workloads/tpch/queries/,
> like 'tpch-q1.test'?
> Thanks. :)
No, that is for TPCH tests. frontend tests are in fe/src/test
--
To view, visit http://gerrit.cloudera.org:8080/3335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I002f75f3330ee319d82213331a5a046ecf198189
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3335/2//COMMIT_MSG
Commit Message:
PS2, Line 7: IMPALA
Please see the comment on this bug first - what does the SQL standard say is the correct behavior?
PS2, Line 9: sub process
What is a "sub process"?
http://gerrit.cloudera.org:8080/#/c/3335/2/fe/src/main/java/com/cloudera/impala/analysis/StringLiteral.java
File fe/src/main/java/com/cloudera/impala/analysis/StringLiteral.java:
Line 79: str.insert(pos + (count++), '\\');
This seems more complex than iterating over the strong one character at a time, and it also might have quadratic complexity if StringBuilder.insert takes linear time.
--
To view, visit http://gerrit.cloudera.org:8080/3335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I002f75f3330ee319d82213331a5a046ecf198189
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: Yes