You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2023/11/29 16:58:50 UTC
[PR] feat: import external Camel applications [camel-k]
squakez opened a new pull request, #4942:
URL: https://github.com/apache/camel-k/pull/4942
<!-- Description -->
With this PR we enable the possibility to import any Camel application deployed on Kubernetes manually or via other tooling and be able to monitor it as a "synthetic" Integration.
We can control the same deployment objects we are using for managed Integrations: Deployment, CronJob and Knative Services.
It works by annotating the specific object we want to import with the `camel.apache.org/integration=my-it` label. The operator creates a synthetic Integration and monitor the resources after the object which created it.
```
$ k label deploy my-camel-sb-svc camel.apache.org/integration=my-it
$ k get it
NAME PHASE RUNTIME PROVIDER RUNTIME VERSION KIT REPLICAS
my-it Running 1
$ k scale deploy my-camel-sb-svc --replicas 2
$ k get it
NAME PHASE RUNTIME PROVIDER RUNTIME VERSION KIT REPLICAS
my-it Running 2
$ k delete deploy my-camel-sb-svc
deployment.apps "my-camel-sb-svc" deleted
$ k get it
NAME PHASE RUNTIME PROVIDER RUNTIME VERSION KIT REPLICAS
my-it Application Missing 0
```
We're covering the main corner cases such as removal of the object which generated the import or the missing selector which would not allow the possibility to monitor the sibling pods. It's a MVP that sets the framework for any possible future feature around monitoring.
Unit and E2E tests to follow.
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
feat: import external Camel applications
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1836270692
:camel: **Thank you for contributing!**
Code Coverage Report :warning: - Coverage changed: 33.6% --> 33.5% (Coverage difference: **-.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1409614170
##########
pkg/cmd/operator/operator.go:
##########
@@ -188,7 +188,6 @@ func Run(healthPort, monitoringPort int32, leaderElection bool, leaderElectionID
selector := labels.NewSelector().Add(*hasIntegrationLabel)
selectors := map[ctrl.Object]cache.ByObject{
- &corev1.Pod{}: {Label: selector},
Review Comment:
for a POC it is ok, but we need to have restore such cache or we are going to experience high memory usage and high traffic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1836254910
:camel: **Thank you for contributing!**
Code Coverage Report :warning: - Coverage changed: 33.6% --> 33.5% (Coverage difference: **-.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1410234240
##########
pkg/cmd/operator/operator.go:
##########
@@ -188,7 +188,6 @@ func Run(healthPort, monitoringPort int32, leaderElection bool, leaderElectionID
selector := labels.NewSelector().Add(*hasIntegrationLabel)
selectors := map[ctrl.Object]cache.ByObject{
- &corev1.Pod{}: {Label: selector},
Review Comment:
Yeah. Even in this same PR I had to do some magic tricks to have it working, ie, watching Knative Service Revisions... at this stage the best option is to ask the user to include the label in the template in order to monitor the generated Pods. Moving to back to this strategy would simplify that part too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1833409201
:camel: **Thank you for contributing!**
Code Coverage Report :warning: - Coverage changed: 33.6% --> 33.3% (Coverage difference: **-.3%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1410608963
##########
config/rbac/operator-role-knative.yaml:
##########
@@ -35,6 +35,14 @@ rules:
- patch
- update
- watch
+- apiGroups:
Review Comment:
No, it's a leftover. I'll remove in next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1836280874
:camel: **Thank you for contributing!**
Code Coverage Report :warning: - Coverage changed: 33.6% --> 33.5% (Coverage difference: **-.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423656190
##########
pkg/apis/camel/v1/integration_types.go:
##########
@@ -220,7 +227,8 @@ const (
IntegrationConditionJolokiaAvailableReason string = "JolokiaAvailable"
// IntegrationConditionProbesAvailableReason --.
IntegrationConditionProbesAvailableReason string = "ProbesAvailable"
-
+ // IntegrationConditionMonitoringPodsAvailableReason used to specify that the Pods generated are available for monitoring.
+ IntegrationConditionMonitoringPodsAvailableReason string = "MonitoringPodsAvailable"
Review Comment:
Not sure if I get why we have a specific reason for "syntetic" pods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1410186010
##########
pkg/cmd/operator/operator.go:
##########
@@ -188,7 +188,6 @@ func Run(healthPort, monitoringPort int32, leaderElection bool, leaderElectionID
selector := labels.NewSelector().Add(*hasIntegrationLabel)
selectors := map[ctrl.Object]cache.ByObject{
- &corev1.Pod{}: {Label: selector},
Review Comment:
Something else I thought is that we don't watch directly the Pods resource at all. If we remove that capability we should be okey. I was already thinking about this optimization because after all, we would always react on events on the manager of those Pods (Deployment). The only cons is that we loose a finer grain check and won't react on minor changes on managed Integration Pods (ie, the user change some value directly on the Pod which does not affect the Deployment). I can do some further testing on this part and we can discuss how to progress once I have some test performed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1840278858
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage changed: 33.6% --> 34.1% (Coverage difference: **+.5%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1440579674
##########
pkg/apis/camel/v1/integration_types_support.go:
##########
@@ -25,8 +25,18 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
+// IntegrationLabel is used to tag k8s object created by a given Integration.
const IntegrationLabel = "camel.apache.org/integration"
+// IntegrationSyntheticLabel is used to tag k8s synthetic Integrations.
+const IntegrationSyntheticLabel = "camel.apache.org/is-synthetic"
+
+// IntegrationImportedKindLabel specifies from what kind of resource an Integration was imported.
+const IntegrationImportedKindLabel = "camel.apache.org/imported-from-kind"
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1875609371
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage changed: 33.6% --> 34.2% (Coverage difference: **+.6%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1409628518
##########
pkg/cmd/operator/operator.go:
##########
@@ -188,7 +188,6 @@ func Run(healthPort, monitoringPort int32, leaderElection bool, leaderElectionID
selector := labels.NewSelector().Add(*hasIntegrationLabel)
selectors := map[ctrl.Object]cache.ByObject{
- &corev1.Pod{}: {Label: selector},
Review Comment:
could be an option yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1410227667
##########
pkg/cmd/operator/operator.go:
##########
@@ -188,7 +188,6 @@ func Run(healthPort, monitoringPort int32, leaderElection bool, leaderElectionID
selector := labels.NewSelector().Add(*hasIntegrationLabel)
selectors := map[ctrl.Object]cache.ByObject{
- &corev1.Pod{}: {Label: selector},
Review Comment:
This was a conscious decision made a while ago by @astefanutti to simplify how we monitor workload regardless of how they have been created (Deployment, StatefulSet, Knative Service, Job, etc) so I guess removing it would bring back the complexity we had in the past.
Also we use pods to grab additional information through the health endpoints.
So I'd suggest so sync up with him
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423843388
##########
pkg/apis/camel/v1/integration_types.go:
##########
@@ -220,7 +227,8 @@ const (
IntegrationConditionJolokiaAvailableReason string = "JolokiaAvailable"
// IntegrationConditionProbesAvailableReason --.
IntegrationConditionProbesAvailableReason string = "ProbesAvailable"
-
+ // IntegrationConditionMonitoringPodsAvailableReason used to specify that the Pods generated are available for monitoring.
+ IntegrationConditionMonitoringPodsAvailableReason string = "MonitoringPodsAvailable"
Review Comment:
I wonder if this should be part of the ready condition, like `Ready=False, Reason="Misconfiguration"` as in fact, camel-k is then not really able to monitor the application, isn't it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1410566994
##########
config/rbac/operator-role-knative.yaml:
##########
@@ -35,6 +35,14 @@ rules:
- patch
- update
- watch
+- apiGroups:
Review Comment:
This will probably needs to be added in the `helm/camel-k/templates/operator-role.yaml` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423844037
##########
pkg/apis/camel/v1/integration_types.go:
##########
@@ -155,7 +155,13 @@ const (
IntegrationPhaseRunning IntegrationPhase = "Running"
// IntegrationPhaseError --.
IntegrationPhaseError IntegrationPhase = "Error"
+ // IntegrationPhaseImportMissing used when the application from which the Integration is imported has been deleted.
+ IntegrationPhaseImportMissing IntegrationPhase = "Application Missing"
+ // IntegrationPhaseCannotMonitor used when the application from which the Integration has not enough information to monitor its pods.
+ IntegrationPhaseCannotMonitor IntegrationPhase = "Cannot Monitor Pods"
Review Comment:
I think that if the deployment is mis configured, then the integration should be in an error status and a condition should report the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423850974
##########
pkg/apis/camel/v1/integration_types_support.go:
##########
@@ -25,8 +25,18 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
+// IntegrationLabel is used to tag k8s object created by a given Integration.
const IntegrationLabel = "camel.apache.org/integration"
+// IntegrationSyntheticLabel is used to tag k8s synthetic Integrations.
+const IntegrationSyntheticLabel = "camel.apache.org/is-synthetic"
+
+// IntegrationImportedKindLabel specifies from what kind of resource an Integration was imported.
+const IntegrationImportedKindLabel = "camel.apache.org/imported-from-kind"
Review Comment:
> I thought that once the user imports an Integration, he wants to control the lifecycle as well
I think it would become very complicated to do it right. In my opinion, the synthetic integration is essentially a read only projection of the status of an camel application so I won't go much further.
> The reconciliation deletion should still exists, when the user remove the importing label because he wants the Deployment to no longer generates a synthetic Integration.
true, but I guess if this should be something that falls in a GC algorithm as I don't know if the way it is implemented as today, then it would work in case of a restart of the operator as you may not receive a deletion event (but have had a look at the code in depth so I may be wrong).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423811527
##########
pkg/apis/camel/v1/integration_types.go:
##########
@@ -220,7 +227,8 @@ const (
IntegrationConditionJolokiaAvailableReason string = "JolokiaAvailable"
// IntegrationConditionProbesAvailableReason --.
IntegrationConditionProbesAvailableReason string = "ProbesAvailable"
-
+ // IntegrationConditionMonitoringPodsAvailableReason used to specify that the Pods generated are available for monitoring.
+ IntegrationConditionMonitoringPodsAvailableReason string = "MonitoringPodsAvailable"
Review Comment:
This could happen when the user has imported an Integration but has not provided the Pod label [1] required by the operator to monitor the status of the Pods.
[1] `$ kubectl patch deployment my-camel-sb-svc --patch '{"spec": {"template": {"metadata": {"labels": {"camel.apache.org/integration": "my-it"}}}}}'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423827128
##########
pkg/apis/camel/v1/integration_types_support.go:
##########
@@ -25,8 +25,18 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
+// IntegrationLabel is used to tag k8s object created by a given Integration.
const IntegrationLabel = "camel.apache.org/integration"
+// IntegrationSyntheticLabel is used to tag k8s synthetic Integrations.
+const IntegrationSyntheticLabel = "camel.apache.org/is-synthetic"
+
+// IntegrationImportedKindLabel specifies from what kind of resource an Integration was imported.
+const IntegrationImportedKindLabel = "camel.apache.org/imported-from-kind"
Review Comment:
The reconciliation deletion should still exists, when the user remove the importing label because he wants the Deployment to no longer generates a synthetic Integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423877190
##########
pkg/apis/camel/v1/integration_types.go:
##########
@@ -220,7 +227,8 @@ const (
IntegrationConditionJolokiaAvailableReason string = "JolokiaAvailable"
// IntegrationConditionProbesAvailableReason --.
IntegrationConditionProbesAvailableReason string = "ProbesAvailable"
-
+ // IntegrationConditionMonitoringPodsAvailableReason used to specify that the Pods generated are available for monitoring.
+ IntegrationConditionMonitoringPodsAvailableReason string = "MonitoringPodsAvailable"
Review Comment:
what I mean is that this check can probably be done when the synthetic integration is created, even before going in the monitor phase as it would signal a misconfigured resource but I may have missed something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1410231061
##########
pkg/cmd/operator/operator.go:
##########
@@ -188,7 +188,6 @@ func Run(healthPort, monitoringPort int32, leaderElection bool, leaderElectionID
selector := labels.NewSelector().Add(*hasIntegrationLabel)
selectors := map[ctrl.Object]cache.ByObject{
- &corev1.Pod{}: {Label: selector},
Review Comment:
Not an option. Altough in principle the idea is good there is a practical problem with the possible status of the Pods at any time. For example, we are correctly reported that a Pod is being rescheduled via the Deployment event change, however, we don't catch correctly the final status, because it starts `Running` (which we detect correctly during the Integration monitoring action) but later can move to a different status (which we can only get watching the Pods events).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1409619742
##########
pkg/cmd/operator/operator.go:
##########
@@ -188,7 +188,6 @@ func Run(healthPort, monitoringPort int32, leaderElection bool, leaderElectionID
selector := labels.NewSelector().Add(*hasIntegrationLabel)
selectors := map[ctrl.Object]cache.ByObject{
- &corev1.Pod{}: {Label: selector},
Review Comment:
Yeah, it's my main concern as well. However, without that we are not able to monitor pods which have not the label (hence, unmanaged). The only possible way to bring that filter back and make it work is to ask the user to add a label to the resource and to include a label into the template that would generate finally the Pods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1875619647
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage changed: 33.6% --> 34.2% (Coverage difference: **+.6%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1440621704
##########
pkg/apis/camel/v1/integration_types.go:
##########
@@ -220,7 +227,8 @@ const (
IntegrationConditionJolokiaAvailableReason string = "JolokiaAvailable"
// IntegrationConditionProbesAvailableReason --.
IntegrationConditionProbesAvailableReason string = "ProbesAvailable"
-
+ // IntegrationConditionMonitoringPodsAvailableReason used to specify that the Pods generated are available for monitoring.
+ IntegrationConditionMonitoringPodsAvailableReason string = "MonitoringPodsAvailable"
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1409619250
##########
pkg/controller/integration/integration_controller_import.go:
##########
@@ -0,0 +1,249 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package integration
+
+import (
+ "context"
+
+ v1 "github.com/apache/camel-k/v2/pkg/apis/camel/v1"
+ "github.com/apache/camel-k/v2/pkg/apis/camel/v1/trait"
+ "github.com/apache/camel-k/v2/pkg/client"
+ "github.com/apache/camel-k/v2/pkg/util/log"
+ "github.com/apache/camel-k/v2/pkg/util/patch"
+ appsv1 "k8s.io/api/apps/v1"
+ batchv1 "k8s.io/api/batch/v1"
+ k8serrors "k8s.io/apimachinery/pkg/api/errors"
+ "k8s.io/apimachinery/pkg/types"
+ servingv1 "knative.dev/serving/pkg/apis/serving/v1"
+ ctrl "sigs.k8s.io/controller-runtime/pkg/client"
+ "sigs.k8s.io/controller-runtime/pkg/reconcile"
+)
+
+// nonManagedCamelAppEnqueueRequestsFromMapFunc represent the function to discover the Integration which has to be woke up: it creates a synthetic
+// Integration if the Integration does not exist. This is used to import external Camel applications.
+func nonManagedCamelAppEnqueueRequestsFromMapFunc(ctx context.Context, c client.Client, adp NonManagedCamelApplicationAdapter) []reconcile.Request {
+ if adp.GetIntegrationName() == "" {
+ return []reconcile.Request{}
+ }
+ it := v1.NewIntegration(adp.GetIntegrationNameSpace(), adp.GetIntegrationName())
+ err := c.Get(ctx, ctrl.ObjectKeyFromObject(&it), &it)
+ if err != nil {
+ if k8serrors.IsNotFound(err) {
+ // We must perform this check to make sure the resource is not being deleted.
+ // In such case it makes no sense to create an Integration after it.
+ err := c.Get(ctx, ctrl.ObjectKeyFromObject(adp.GetAppObj()), adp.GetAppObj())
+ if err != nil {
+ if k8serrors.IsNotFound(err) {
+ return []reconcile.Request{}
+ }
+ log.Errorf(err, "Some error happened while trying to get %s %s resource", adp.GetName(), adp.GetKind())
+ }
+ createSyntheticIntegration(&it, adp)
Review Comment:
I'm not sure if it is a good idea to create a syntetic integration here, maybe we must create a dedicated informer ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1832365761
> > quick comment before looking at the code: we can maybe simplify it by using a static label `camel.apache.org/supervise=true` and take the name of the deployment/etc/
>
> Unfortunately not. Or at least, it would not be that easy. The way we are watching objects is quite limited to the presence of the `camel.apache.org/integration` label. If we remove such a requirement, we'd need to watch all objects. You will see later that we already had to remove the filter from Pods, in order to be able to watch also the non managed ones. I think that if we remove this constraint we may degrade the performance too much.
mh, I see.
we may need to think how to make the process simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1832351973
> quick comment before looking at the code: we can maybe simplify it by using a static label `camel.apache.org/supervise=true` and take the name of the deployment/etc/
Unfortunately not. Or at least, it would not be that easy. The way we are watching objects is quite limited to the presence of the `camel.apache.org/integration` label. If we remove such a requirement, we'd need to watch all objects. You will see later that we already had to remove the filter from Pods, in order to be able to watch also the non managed ones. I think that if we remove this constraint we may degrade the performance too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1412209801
##########
pkg/controller/integration/integration_controller_import.go:
##########
@@ -0,0 +1,249 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package integration
+
+import (
+ "context"
+
+ v1 "github.com/apache/camel-k/v2/pkg/apis/camel/v1"
+ "github.com/apache/camel-k/v2/pkg/apis/camel/v1/trait"
+ "github.com/apache/camel-k/v2/pkg/client"
+ "github.com/apache/camel-k/v2/pkg/util/log"
+ "github.com/apache/camel-k/v2/pkg/util/patch"
+ appsv1 "k8s.io/api/apps/v1"
+ batchv1 "k8s.io/api/batch/v1"
+ k8serrors "k8s.io/apimachinery/pkg/api/errors"
+ "k8s.io/apimachinery/pkg/types"
+ servingv1 "knative.dev/serving/pkg/apis/serving/v1"
+ ctrl "sigs.k8s.io/controller-runtime/pkg/client"
+ "sigs.k8s.io/controller-runtime/pkg/reconcile"
+)
+
+// nonManagedCamelAppEnqueueRequestsFromMapFunc represent the function to discover the Integration which has to be woke up: it creates a synthetic
+// Integration if the Integration does not exist. This is used to import external Camel applications.
+func nonManagedCamelAppEnqueueRequestsFromMapFunc(ctx context.Context, c client.Client, adp NonManagedCamelApplicationAdapter) []reconcile.Request {
+ if adp.GetIntegrationName() == "" {
+ return []reconcile.Request{}
+ }
+ it := v1.NewIntegration(adp.GetIntegrationNameSpace(), adp.GetIntegrationName())
+ err := c.Get(ctx, ctrl.ObjectKeyFromObject(&it), &it)
+ if err != nil {
+ if k8serrors.IsNotFound(err) {
+ // We must perform this check to make sure the resource is not being deleted.
+ // In such case it makes no sense to create an Integration after it.
+ err := c.Get(ctx, ctrl.ObjectKeyFromObject(adp.GetAppObj()), adp.GetAppObj())
+ if err != nil {
+ if k8serrors.IsNotFound(err) {
+ return []reconcile.Request{}
+ }
+ log.Errorf(err, "Some error happened while trying to get %s %s resource", adp.GetName(), adp.GetKind())
+ }
+ createSyntheticIntegration(&it, adp)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1410237633
##########
pkg/cmd/operator/operator.go:
##########
@@ -188,7 +188,6 @@ func Run(healthPort, monitoringPort int32, leaderElection bool, leaderElectionID
selector := labels.NewSelector().Add(*hasIntegrationLabel)
selectors := map[ctrl.Object]cache.ByObject{
- &corev1.Pod{}: {Label: selector},
Review Comment:
we can improve it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1832344997
quick comment before looking at the code: we can maybe simplify it by using a static label `camel.apache.org/supervise=true` and take the name of the deployment/etc/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1832344906
:camel: **Thank you for contributing!**
Code Coverage Report :warning: - Coverage changed: 33.6% --> 33.3% (Coverage difference: **-.3%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1838810792
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage changed: 33.6% --> 34.1% (Coverage difference: **+.5%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423654910
##########
pkg/apis/camel/v1/integration_types.go:
##########
@@ -155,7 +155,13 @@ const (
IntegrationPhaseRunning IntegrationPhase = "Running"
// IntegrationPhaseError --.
IntegrationPhaseError IntegrationPhase = "Error"
+ // IntegrationPhaseImportMissing used when the application from which the Integration is imported has been deleted.
+ IntegrationPhaseImportMissing IntegrationPhase = "Application Missing"
+ // IntegrationPhaseCannotMonitor used when the application from which the Integration has not enough information to monitor its pods.
+ IntegrationPhaseCannotMonitor IntegrationPhase = "Cannot Monitor Pods"
Review Comment:
I rather use conditions than phases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423848995
##########
pkg/apis/camel/v1/integration_types.go:
##########
@@ -220,7 +227,8 @@ const (
IntegrationConditionJolokiaAvailableReason string = "JolokiaAvailable"
// IntegrationConditionProbesAvailableReason --.
IntegrationConditionProbesAvailableReason string = "ProbesAvailable"
-
+ // IntegrationConditionMonitoringPodsAvailableReason used to specify that the Pods generated are available for monitoring.
+ IntegrationConditionMonitoringPodsAvailableReason string = "MonitoringPodsAvailable"
Review Comment:
The "problem" is that the monitoring is not direct, as we watch for Pods with a given label. But yeah, we can set the status and the reason you're proposing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4942:
URL: https://github.com/apache/camel-k/pull/4942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1840350926
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage changed: 33.6% --> 34.1% (Coverage difference: **+.5%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1840393778
An additional comment which may be useful in the future. Before reaching this state, I've worked on a few experiments. The result of them may return useful eventually.
The first experiment was to let the operator assume the control of the managed fields of a Deployment: https://github.com/apache/camel-k/commit/1e4aaaaa5d6fde8aab49121ff666ef355b904279#diff-de2d026ce0dc415e68ee971f300e7320de019cc68c5171cf76425859587f1a85 - this solution was discarded because it clearly overlap the external deployment procedure (ie, triggering a new deployment).
The second one had the same problem (overlapping external deployment): https://github.com/squakez/camel-k/tree/feat/it_import_delete_deploy - in this case we were deleting the deployment, in order to let the operator create and manage one from scratch.
Although they are aggressive approaches, they may be used eventually in a sort of "dry-run" operation to let the user decide if a given deployment can be substituted with a managed Integration (at the price of forcefully deleting the original deployment).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423663352
##########
pkg/apis/camel/v1/integration_types_support.go:
##########
@@ -25,8 +25,18 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
+// IntegrationLabel is used to tag k8s object created by a given Integration.
const IntegrationLabel = "camel.apache.org/integration"
+// IntegrationSyntheticLabel is used to tag k8s synthetic Integrations.
+const IntegrationSyntheticLabel = "camel.apache.org/is-synthetic"
+
+// IntegrationImportedKindLabel specifies from what kind of resource an Integration was imported.
+const IntegrationImportedKindLabel = "camel.apache.org/imported-from-kind"
Review Comment:
maybe we can use ownership here so the resource is also the owner of the synthetic integration and can get deleted by kubernetes gc ? it could also simplify the reconciler as you probably won't need to delete the resource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423825891
##########
pkg/apis/camel/v1/integration_types_support.go:
##########
@@ -25,8 +25,18 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
+// IntegrationLabel is used to tag k8s object created by a given Integration.
const IntegrationLabel = "camel.apache.org/integration"
+// IntegrationSyntheticLabel is used to tag k8s synthetic Integrations.
+const IntegrationSyntheticLabel = "camel.apache.org/is-synthetic"
+
+// IntegrationImportedKindLabel specifies from what kind of resource an Integration was imported.
+const IntegrationImportedKindLabel = "camel.apache.org/imported-from-kind"
Review Comment:
That's something I left out on purpose. I thought that once the user imports an Integration, he wants to control the lifecycle as well. If we link the lifecycle of the Integration to the Deployment, then the "Application Missing" makes no sense as the Integration would be garbage collected accordingly. It's not a strong opinion though, so, if we think it makes sense to do it, I can work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423813547
##########
pkg/apis/camel/v1/integration_types.go:
##########
@@ -155,7 +155,13 @@ const (
IntegrationPhaseRunning IntegrationPhase = "Running"
// IntegrationPhaseError --.
IntegrationPhaseError IntegrationPhase = "Error"
+ // IntegrationPhaseImportMissing used when the application from which the Integration is imported has been deleted.
+ IntegrationPhaseImportMissing IntegrationPhase = "Application Missing"
+ // IntegrationPhaseCannotMonitor used when the application from which the Integration has not enough information to monitor its pods.
+ IntegrationPhaseCannotMonitor IntegrationPhase = "Cannot Monitor Pods"
Review Comment:
For both "Application Missing" and "Cannot Monitor Pods"? Which should be the phase in this case? I think neither `Ready` or `Error`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1875543439
:camel: **Thank you for contributing!** :camel:
Unable to create **Coverage Report** :warning:.
Merge conflicts found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: import external Camel applications [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#issuecomment-1875604324
@lburgazzoli I think I've addressed the concerns of your last review. About the possibility to miss an event, now this should be covered by the same monitoring action which is in charge to be reconciled and eventually capture any possible missing delete event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org