You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/06/13 07:27:49 UTC
[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3383:
[ZEPPELIN-4104] Zeppelin Interpreter On Docker
liuxunorg commented on a change in pull request #3383: [ZEPPELIN-4104] Zeppelin Interpreter On Docker
URL: https://github.com/apache/zeppelin/pull/3383#discussion_r293238678
##########
File path: zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zeppelin.interpreter.launcher;
+
+import org.apache.zeppelin.conf.ZeppelinConfiguration;
+import org.apache.zeppelin.interpreter.recovery.RecoveryStorage;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Map;
+
+/**
+ * Interpreter Launcher which use shell script to launch the interpreter process.
+ */
+public class DockerInterpreterLauncher extends InterpreterLauncher {
+ private static final Logger LOGGER = LoggerFactory.getLogger(DockerInterpreterLauncher.class);
+
+ private InterpreterLaunchContext context;
+
+ public DockerInterpreterLauncher(ZeppelinConfiguration zConf, RecoveryStorage recoveryStorage)
+ throws IOException {
+ super(zConf, recoveryStorage);
+ }
+
+ @Override
+ public InterpreterClient launch(InterpreterLaunchContext context) throws IOException {
+ LOGGER.info("Launching Interpreter: " + context.getInterpreterSettingGroup());
+ this.context = context;
+ this.properties = context.getProperties();
+ int connectTimeout = getConnectTimeout();
+ if (connectTimeout < 200000) {
Review comment:
This configuration item is already in `zeppelin-site.xml`, `zeppelin.interpreter.connect.timeout`
ok, I am modifying the log message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
Re: [GitHub] [zeppelin] liuxunorg commented on a change in pull
request #3383: [ZEPPELIN-4104] Zeppelin Interpreter On Docker
Posted by Xun Liu <ne...@163.com>.
According to the shared settings of the interpreter in zeppelin, shared \ Per node \ Per user settings,
Each interpreter process will be a separate docker container.
> On Jun 13, 2019, at 9:51 PM, tecgie88@yahoo.com.INVALID wrote:
>
> I have question about the behavior.
>
> Suppose user uses the per note scope and his notebook consists of python, r, and sql paragraphs. How many interpreter containers will be spawned when the note is run?
>
> Thanks
>
>> On Jun 13, 2019, at 3:27 AM, GitBox <gi...@apache.org> wrote:
>>
>> liuxunorg commented on a change in pull request #3383: [ZEPPELIN-4104] Zeppelin Interpreter On Docker
>> URL: https://github.com/apache/zeppelin/pull/3383#discussion_r293238678
>>
>>
>>
>> ##########
>> File path: zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java
>> ##########
>> @@ -0,0 +1,79 @@
>> +/*
>> + * Licensed to the Apache Software Foundation (ASF) under one or more
>> + * contributor license agreements. See the NOTICE file distributed with
>> + * this work for additional information regarding copyright ownership.
>> + * The ASF licenses this file to You under the Apache License, Version 2.0
>> + * (the "License"); you may not use this file except in compliance with
>> + * the License. You may obtain a copy of the License at
>> + *
>> + * http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +package org.apache.zeppelin.interpreter.launcher;
>> +
>> +import org.apache.zeppelin.conf.ZeppelinConfiguration;
>> +import org.apache.zeppelin.interpreter.recovery.RecoveryStorage;
>> +import org.slf4j.Logger;
>> +import org.slf4j.LoggerFactory;
>> +
>> +import java.io.IOException;
>> +import java.util.Map;
>> +
>> +/**
>> + * Interpreter Launcher which use shell script to launch the interpreter process.
>> + */
>> +public class DockerInterpreterLauncher extends InterpreterLauncher {
>> + private static final Logger LOGGER = LoggerFactory.getLogger(DockerInterpreterLauncher.class);
>> +
>> + private InterpreterLaunchContext context;
>> +
>> + public DockerInterpreterLauncher(ZeppelinConfiguration zConf, RecoveryStorage recoveryStorage)
>> + throws IOException {
>> + super(zConf, recoveryStorage);
>> + }
>> +
>> + @Override
>> + public InterpreterClient launch(InterpreterLaunchContext context) throws IOException {
>> + LOGGER.info("Launching Interpreter: " + context.getInterpreterSettingGroup());
>> + this.context = context;
>> + this.properties = context.getProperties();
>> + int connectTimeout = getConnectTimeout();
>> + if (connectTimeout < 200000) {
>>
>> Review comment:
>> This configuration item is already in `zeppelin-site.xml`, `zeppelin.interpreter.connect.timeout`
>> ok, I am modifying the log message.
>>
>> ----------------------------------------------------------------
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>>
>> With regards,
>> Apache Git Services
Re: [GitHub] [zeppelin] liuxunorg commented on a change in pull request #3383: [ZEPPELIN-4104] Zeppelin Interpreter On Docker
Posted by te...@yahoo.com.INVALID.
I have question about the behavior.
Suppose user uses the per note scope and his notebook consists of python, r, and sql paragraphs. How many interpreter containers will be spawned when the note is run?
Thanks
> On Jun 13, 2019, at 3:27 AM, GitBox <gi...@apache.org> wrote:
>
> liuxunorg commented on a change in pull request #3383: [ZEPPELIN-4104] Zeppelin Interpreter On Docker
> URL: https://github.com/apache/zeppelin/pull/3383#discussion_r293238678
>
>
>
> ##########
> File path: zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java
> ##########
> @@ -0,0 +1,79 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements. See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.apache.zeppelin.interpreter.launcher;
> +
> +import org.apache.zeppelin.conf.ZeppelinConfiguration;
> +import org.apache.zeppelin.interpreter.recovery.RecoveryStorage;
> +import org.slf4j.Logger;
> +import org.slf4j.LoggerFactory;
> +
> +import java.io.IOException;
> +import java.util.Map;
> +
> +/**
> + * Interpreter Launcher which use shell script to launch the interpreter process.
> + */
> +public class DockerInterpreterLauncher extends InterpreterLauncher {
> + private static final Logger LOGGER = LoggerFactory.getLogger(DockerInterpreterLauncher.class);
> +
> + private InterpreterLaunchContext context;
> +
> + public DockerInterpreterLauncher(ZeppelinConfiguration zConf, RecoveryStorage recoveryStorage)
> + throws IOException {
> + super(zConf, recoveryStorage);
> + }
> +
> + @Override
> + public InterpreterClient launch(InterpreterLaunchContext context) throws IOException {
> + LOGGER.info("Launching Interpreter: " + context.getInterpreterSettingGroup());
> + this.context = context;
> + this.properties = context.getProperties();
> + int connectTimeout = getConnectTimeout();
> + if (connectTimeout < 200000) {
>
> Review comment:
> This configuration item is already in `zeppelin-site.xml`, `zeppelin.interpreter.connect.timeout`
> ok, I am modifying the log message.
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services