You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ra...@apache.org on 2019/03/30 19:28:47 UTC
[cordova-lib] branch master updated: Refactor plugin_fetch.spec
(#758)
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git
The following commit(s) were added to refs/heads/master by this push:
new c78c974 Refactor plugin_fetch.spec (#758)
c78c974 is described below
commit c78c9743960e9e2d5f8bdc2fa6a097b6807ae68d
Author: Raphael von der Grün <ra...@gmail.com>
AuthorDate: Sat Mar 30 20:28:43 2019 +0100
Refactor plugin_fetch.spec (#758)
- Refactored the test to be more readable, robust and self contained
- Removed the reliance on the outdated fixtures
- Moved the test to spec/ since it is actually a unit test
---
integration-tests/plugin_fetch.spec.js | 531 ------------------------
spec/cordova/plugin/add.getFetchVersion.spec.js | 444 ++++++++++++++++++++
spec/cordova/plugin/add.spec.js | 2 +-
3 files changed, 445 insertions(+), 532 deletions(-)
diff --git a/integration-tests/plugin_fetch.spec.js b/integration-tests/plugin_fetch.spec.js
deleted file mode 100644
index 1a31f3d..0000000
--- a/integration-tests/plugin_fetch.spec.js
+++ /dev/null
@@ -1,531 +0,0 @@
-/**
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-*/
-
-// TODO: all of these tests should go as unit tests to src/cordova/plugin/add
-
-var fs = require('fs-extra');
-var plugin = require('../src/cordova/plugin/add');
-var helpers = require('../spec/helpers');
-var path = require('path');
-var events = require('cordova-common').events;
-
-var testPluginVersions = [
- '0.0.2',
- '0.7.0',
- '1.0.0',
- '1.1.0',
- '1.1.3',
- '1.3.0',
- '1.7.0',
- '1.7.1',
- '2.0.0-rc.1',
- '2.0.0-rc.2',
- '2.0.0',
- '2.3.0'
-];
-
-var cordovaVersion = '3.4.2';
-
-var tempDir = helpers.tmpDir('plugin_fetch_spec');
-var project = path.join(tempDir, 'project');
-
-var warnings = [];
-
-// Used to extract the constraint, the installed version, and the required
-// semver range from a warning message
-var UNMET_REQ_REGEX = /\s+([^\s]+)[^\d]+(\d+\.\d+\.\d+) in project, (.+) required\)/;
-
-// We generate warnings when we don't fetch latest. Collect them to make sure we
-// are making the correct warnings
-events.on('warn', function (warning) {
- warnings.push(warning);
-});
-
-// Tests a sample engine against the installed platforms/plugins in our test
-// project
-function testEngineWithProject (done, testEngine, testResult) {
- return plugin.getFetchVersion(project,
- {
- 'version': '2.3.0',
- 'name': 'test-plugin',
- 'engines': { 'cordovaDependencies': testEngine },
- 'versions': testPluginVersions
- }, cordovaVersion)
- .then(function (toFetch) {
- expect(toFetch).toBe(testResult);
- done();
- });
-}
-
-// Checks the warnings that were printed by the CLI to ensure that the code is
-// listing the correct reasons for failure. Checks against the global warnings
-// object which is reset before each test
-function checkUnmetRequirements (requirements) {
- var reqWarnings = [];
-
- warnings.forEach(function (warning) {
- var extracted = UNMET_REQ_REGEX.exec(warning);
- if (extracted) {
- reqWarnings.push({
- dependency: extracted[1],
- installed: extracted[2],
- required: extracted[3]
- });
- }
- });
- expect(reqWarnings.length).toEqual(requirements.length);
-
- requirements.forEach(function (requirement) {
- expect(reqWarnings).toContainArray(function (extractedWarning) {
- return extractedWarning.dependency === requirement.dependency.trim() &&
- extractedWarning.installed === requirement.installed.trim() &&
- extractedWarning.required === requirement.required.trim();
- }, requirement);
- });
-}
-
-// Helper functions for creating the requirements objects taken by
-// checkUnmetRequirements()
-function getPlatformRequirement (requirement) {
- return {
- dependency: 'cordova-android',
- installed: '3.1.0',
- required: requirement
- };
-}
-
-function getCordovaRequirement (requirement) {
- return {
- dependency: 'cordova',
- installed: cordovaVersion,
- required: requirement
- };
-}
-
-function getPluginRequirement (requirement) {
- return {
- dependency: 'ca.filmaj.AndroidPlugin',
- installed: '4.2.0',
- required: requirement
- };
-}
-
-// Generates a callback that checks warning messages after the test is complete
-function getWarningCheckCallback (requirements) {
- return function () {
- checkUnmetRequirements(requirements);
- };
-}
-var fixtures = path.join(__dirname, '..', 'spec', 'cordova', 'fixtures');
-
-function createTestProject () {
- // Get the base project
- fs.copySync(path.join(fixtures, 'base'), project);
-
- // Copy a platform and a plugin to our sample project
- fs.copySync(
- path.join(fixtures, 'platforms', helpers.testPlatform),
- path.join(project, 'platforms', helpers.testPlatform));
- fs.copySync(
- path.join(fixtures, 'plugins/android'),
- path.join(project, 'plugins/android'));
-}
-
-function removeTestProject () {
- fs.removeSync(tempDir);
-}
-
-describe('plugin fetching version selection', function () {
- createTestProject();
- beforeEach(function () {
- jasmine.addMatchers({
- 'toContainArray': function () {
- return {
- compare: function (actual, expected) {
- var result = {};
- result.pass = false;
- for (var i = 0; i < actual.length; i++) {
- if (expected(actual[i])) {
- result.pass = true;
- break;
- }
- }
- return result;
- }
- };
- }
- });
-
- warnings = [];
- });
-
- it('Test 001 : should handle a mix of upper bounds and single versions', function () {
- var testEngine = {
- '0.0.0': { 'cordova-android': '1.0.0' },
- '0.0.2': { 'cordova-android': '>1.0.0' },
- '<1.0.0': { 'cordova-android': '<2.0.0' },
- '1.0.0': { 'cordova-android': '>2.0.0' },
- '1.7.0': { 'cordova-android': '>4.0.0' },
- '<2.3.0': { 'cordova-android': '<6.1.1' },
- '2.3.0': { 'cordova-android': '6.1.1' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('6.1.1')
- ]);
- return testEngineWithProject(after, testEngine, '1.3.0');
- }, 6000);
-
- it('Test 002 : should apply upper bound engine constraints when there are no unspecified constraints above the upper bound', function () {
- var testEngine = {
- '1.0.0': { 'cordova-android': '>2.0.0' },
- '1.7.0': { 'cordova-android': '>4.0.0' },
- '<2.3.0': {
- 'cordova-android': '<6.1.1',
- 'ca.filmaj.AndroidPlugin': '<1.0.0'
- },
- '2.3.0': { 'cordova-android': '6.1.1' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('6.1.1')
- ]);
- return testEngineWithProject(after, testEngine, null);
- });
-
- it('Test 003 : should apply upper bound engine constraints when there are unspecified constraints above the upper bound', function () {
- var testEngine = {
- '0.0.0': {},
- '2.0.0': { 'cordova-android': '~5.0.0' },
- '<1.0.0': { 'cordova-android': '>5.0.0' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('~5.0.0')
- ]);
- return testEngineWithProject(after, testEngine, '1.7.1');
-
- });
-
- it('Test 004 : should handle the case where there are no constraints for earliest releases', function () {
- var testEngine = {
- '1.0.0': { 'cordova-android': '~5.0.0' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('~5.0.0')
- ]);
- return testEngineWithProject(after, testEngine, '0.7.0');
-
- });
-
- it('Test 005 : should handle the case where the lowest version is unsatisfied', function () {
- var testEngine = {
- '0.0.2': { 'cordova-android': '~5.0.0' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('~5.0.0')
- ]);
- return testEngineWithProject(after, testEngine, null);
-
- });
-
- it('Test 006 : should handle upperbounds if no single version constraints are given', function () {
- var testEngine = {
- '<1.0.0': { 'cordova-android': '<2.0.0' }
- };
-
- var after = getWarningCheckCallback([]);
-
- return testEngineWithProject(after, testEngine, '2.3.0');
-
- });
-
- it('Test 007 : should apply upper bounds greater than highest version', function () {
- var testEngine = {
- '0.0.0': {},
- '<5.0.0': { 'cordova-android': '<2.0.0' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('<2.0.0')
- ]);
-
- return testEngineWithProject(after, testEngine, null);
-
- });
-
- it('Test 008 : should treat empty constraints as satisfied', function () {
- var testEngine = {
- '1.0.0': {},
- '1.1.0': { 'cordova-android': '>5.0.0' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('>5.0.0')
- ]);
-
- return testEngineWithProject(after, testEngine, '1.0.0');
-
- });
-
- it('Test 009 : should ignore an empty cordovaDependencies entry', function () {
- var testEngine = {};
-
- var after = getWarningCheckCallback([]);
-
- return testEngineWithProject(after, testEngine, null);
-
- });
-
- it('Test 010 : should ignore a badly formatted semver range', function () {
- var testEngine = {
- '1.1.3': { 'cordova-android': 'badSemverRange' }
- };
-
- var after = getWarningCheckCallback([]);
-
- return testEngineWithProject(after, testEngine, '2.3.0');
-
- });
-
- it('Test 011 : should respect unreleased versions in constraints', function () {
- var testEngine = {
- '1.0.0': { 'cordova-android': '3.1.0' },
- '1.1.2': { 'cordova-android': '6.1.1' },
- '1.3.0': { 'cordova-android': '6.1.1' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('6.1.1')
- ]);
-
- return testEngineWithProject(after, testEngine, '1.1.0');
-
- });
-
- it('Test 012 : should respect plugin constraints', function () {
- var testEngine = {
- '0.0.0': { 'ca.filmaj.AndroidPlugin': '1.2.0' },
- '1.1.3': { 'ca.filmaj.AndroidPlugin': '<5.0.0 || >2.3.0' },
- '2.3.0': { 'ca.filmaj.AndroidPlugin': '6.1.1' }
- };
-
- var after = getWarningCheckCallback([
- getPluginRequirement('6.1.1')
- ]);
-
- return testEngineWithProject(after, testEngine, '2.0.0');
-
- });
-
- it('Test 013 : should respect cordova constraints', function () {
- var testEngine = {
- '0.0.0': { 'cordova': '>1.0.0' },
- '1.1.3': { 'cordova': '<3.0.0 || >4.0.0' },
- '2.3.0': { 'cordova': '6.1.1' }
- };
-
- var after = getWarningCheckCallback([
- getCordovaRequirement('6.1.1')
- ]);
-
- return testEngineWithProject(after, testEngine, '1.1.0');
-
- });
-
- it('Test 014 : should not include pre-release versions', function () {
- var testEngine = {
- '0.0.0': {},
- '2.0.0': { 'cordova-android': '>5.0.0' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('>5.0.0')
- ]);
-
- // Should not return 2.0.0-rc.2
- return testEngineWithProject(after, testEngine, '1.7.1');
-
- });
-
- it('Test 015 : should not fail if there is no engine in the npm info', function () {
- return plugin.getFetchVersion(project, {
- version: '2.3.0',
- name: 'test-plugin',
- versions: testPluginVersions
- }, cordovaVersion)
- .then(function (toFetch) {
- expect(toFetch).toBe(null);
- });
- });
-
- it('Test 016 : should not fail if there is no cordovaDependencies in the engines', function () {
- var after = getWarningCheckCallback([]);
-
- return plugin.getFetchVersion(project, {
- version: '2.3.0',
- name: 'test-plugin',
- versions: testPluginVersions,
- engines: {
- 'node': '>7.0.0',
- 'npm': '~2.0.0'
- }
- }, cordovaVersion)
- .then(function (toFetch) {
- expect(toFetch).toBe(null);
- after();
- });
-
- });
-
- it('Test 017 : should handle extra whitespace', function () {
- var testEngine = {
- ' 1.0.0 ': {},
- '2.0.0 ': { ' cordova-android': '~5.0.0 ' },
- ' < 1.0.0\t': { ' cordova-android ': ' > 5.0.0' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('~5.0.0')
- ]);
-
- return testEngineWithProject(after, testEngine, '1.7.1');
-
- });
-
- it('Test 018 : should ignore badly typed version requirement entries', function () {
- var testEngine = {
- '1.1.0': ['cordova', '5.0.0'],
- '1.3.0': undefined,
- '1.7.0': null
- };
-
- var after = getWarningCheckCallback([]);
-
- return testEngineWithProject(after, testEngine, '2.3.0');
-
- });
-
- it('Test 019 : should ignore badly typed constraint entries', function () {
- var testEngine = {
- '0.0.2': { 'cordova': 1 },
- '0.7.0': { 'cordova': {} },
- '1.0.0': { 'cordova': undefined },
- '1.1.3': { 8: '5.0.0' },
- '1.3.0': { 'cordova': [] },
- '1.7.1': { 'cordova': null }
- };
-
- var after = getWarningCheckCallback([]);
-
- return testEngineWithProject(after, testEngine, '2.3.0');
-
- });
-
- it('Test 020 : should ignore bad semver versions', function () {
- var testEngine = {
- '0.0.0': { 'cordova-android': '5.0.0' },
- 'notAVersion': { 'cordova-android': '3.1.0' },
- '^1.1.2': { 'cordova-android': '3.1.0' },
- '<=1.3.0': { 'cordova-android': '3.1.0' },
- '1.0': { 'cordova-android': '3.1.0' },
- '2': { 'cordova-android': '3.1.0' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('5.0.0')
- ]);
-
- return testEngineWithProject(after, testEngine, null);
- });
-
- it('Test 021 : should not fail if there are bad semver versions', function () {
- var testEngine = {
- 'notAVersion': { 'cordova-android': '3.1.0' },
- '^1.1.2': { 'cordova-android': '3.1.0' },
- '<=1.3.0': { 'cordova-android': '3.1.0' },
- '1.0.0': { 'cordova-android': '~3' }, // Good semver
- '2.0.0': { 'cordova-android': '5.1.0' }, // Good semver
- '1.0': { 'cordova-android': '3.1.0' },
- '2': { 'cordova-android': '3.1.0' }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('5.1.0')
- ]);
-
- return testEngineWithProject(after, testEngine, '1.7.1');
- });
-
- it('Test 022 : should properly warn about multiple unmet requirements', function () {
- var testEngine = {
- '1.7.0': {
- 'cordova-android': '>5.1.0',
- 'ca.filmaj.AndroidPlugin': '3.1.0',
- 'cordova': '3.4.2'
- }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('>5.1.0'),
- getPluginRequirement('3.1.0')
- ]);
-
- return testEngineWithProject(after, testEngine, '1.3.0');
- });
-
- it('Test 023 : should properly warn about both unmet latest and upper bound requirements', function () {
- var testEngine = {
- '1.7.0': { 'cordova-android': '>5.1.0' },
- '<5.0.0': {
- 'cordova-android': '>7.1.0',
- 'ca.filmaj.AndroidPlugin': '3.1.0'
- }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('>5.1.0 AND >7.1.0'),
- getPluginRequirement('3.1.0')
- ]);
-
- return testEngineWithProject(after, testEngine, null);
- });
-
- it('Test 024 : should not warn about versions past latest', function () {
- var testEngine = {
- '1.7.0': { 'cordova-android': '>5.1.0' },
- '7.0.0': {
- 'cordova-android': '>7.1.0',
- 'ca.filmaj.AndroidPlugin': '3.1.0'
- }
- };
-
- var after = getWarningCheckCallback([
- getPlatformRequirement('>5.1.0')
- ]);
-
- return testEngineWithProject(after, testEngine, '1.3.0');
- });
-
- it('Test 025 : clean up after plugin fetch spec', function () {
- removeTestProject();
- });
-});
diff --git a/spec/cordova/plugin/add.getFetchVersion.spec.js b/spec/cordova/plugin/add.getFetchVersion.spec.js
new file mode 100644
index 0000000..00c667b
--- /dev/null
+++ b/spec/cordova/plugin/add.getFetchVersion.spec.js
@@ -0,0 +1,444 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+const { events } = require('cordova-common');
+const cordovaUtil = require('../../../src/cordova/util');
+const pluginUtil = require('../../../src/cordova/plugin/util');
+const pluginAdd = require('../../../src/cordova/plugin/add');
+
+const cordovaVersion = '3.4.2';
+
+// Used to extract the constraint, the installed version, and the required
+// semver range from a warning message
+const UNMET_REQ_REGEX = /\s+([^\s]+)[^\d]+(\d+\.\d+\.\d+) in project, (.+) required\)/;
+
+function unmetRequirementsCollector (warning) {
+ const match = UNMET_REQ_REGEX.exec(warning);
+ if (!match) return;
+
+ unmetRequirementsCollector.store.push({
+ dependency: match[1],
+ installed: match[2],
+ required: match[3]
+ });
+}
+
+// Checks the warnings that were printed by the CLI to ensure that the code is
+// listing the correct reasons for failure. Checks against the global warnings
+// object which is reset before each test
+function expectUnmetRequirements (expected) {
+ const actual = unmetRequirementsCollector.store;
+ expect(actual).toEqual(jasmine.arrayWithExactContents(expected));
+}
+
+// Helper functions for creating the requirements objects taken by
+// expectUnmetRequirements()
+function getPlatformRequirement (requirement) {
+ return {
+ dependency: 'cordova-android',
+ installed: '3.1.0',
+ required: requirement
+ };
+}
+
+function getCordovaRequirement (requirement) {
+ return {
+ dependency: 'cordova',
+ installed: cordovaVersion,
+ required: requirement
+ };
+}
+
+function getPluginRequirement (requirement) {
+ return {
+ dependency: 'ca.filmaj.AndroidPlugin',
+ installed: '4.2.0',
+ required: requirement
+ };
+}
+
+describe('plugin fetching version selection', () => {
+ let project, testPlugin;
+
+ beforeEach(() => {
+ unmetRequirementsCollector.store = [];
+
+ // We generate warnings when we don't fetch latest. Collect them to make sure we
+ // are making the correct warnings
+ events.on('warn', unmetRequirementsCollector);
+
+ testPlugin = {
+ 'version': '2.3.0',
+ 'name': 'test-plugin',
+ 'engines': { 'cordovaDependencies': {} },
+ 'versions': [
+ '0.0.2',
+ '0.7.0',
+ '1.0.0',
+ '1.1.0',
+ '1.1.3',
+ '1.3.0',
+ '1.7.0',
+ '1.7.1',
+ '2.0.0-rc.1',
+ '2.0.0-rc.2',
+ '2.0.0',
+ '2.3.0'
+ ]
+ };
+
+ spyOn(pluginUtil, 'getInstalledPlugins').and.returnValue([
+ { id: 'ca.filmaj.AndroidPlugin', version: '4.2.0' }
+ ]);
+ spyOn(cordovaUtil, 'getInstalledPlatformsWithVersions').and.returnValue(
+ Promise.resolve({ android: '3.1.0' })
+ );
+ });
+
+ afterEach(() => {
+ events.removeListener('warn', unmetRequirementsCollector);
+ });
+
+ function getFetchVersion (plugin) {
+ return pluginAdd.getFetchVersion(project, plugin, cordovaVersion);
+ }
+
+ it('Test 001 : should handle a mix of upper bounds and single versions', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '0.0.0': { 'cordova-android': '1.0.0' },
+ '0.0.2': { 'cordova-android': '>1.0.0' },
+ '<1.0.0': { 'cordova-android': '<2.0.0' },
+ '1.0.0': { 'cordova-android': '>2.0.0' },
+ '1.7.0': { 'cordova-android': '>4.0.0' },
+ '<2.3.0': { 'cordova-android': '<6.1.1' },
+ '2.3.0': { 'cordova-android': '6.1.1' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('1.3.0');
+ expectUnmetRequirements([ getPlatformRequirement('6.1.1') ]);
+ });
+ });
+
+ it('Test 002 : should apply upper bound engine constraints when there are no unspecified constraints above the upper bound', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '1.0.0': { 'cordova-android': '>2.0.0' },
+ '1.7.0': { 'cordova-android': '>4.0.0' },
+ '<2.3.0': {
+ 'cordova-android': '<6.1.1',
+ 'ca.filmaj.AndroidPlugin': '<1.0.0'
+ },
+ '2.3.0': { 'cordova-android': '6.1.1' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe(null);
+ expectUnmetRequirements([ getPlatformRequirement('6.1.1') ]);
+ });
+ });
+
+ it('Test 003 : should apply upper bound engine constraints when there are unspecified constraints above the upper bound', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '0.0.0': {},
+ '2.0.0': { 'cordova-android': '~5.0.0' },
+ '<1.0.0': { 'cordova-android': '>5.0.0' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('1.7.1');
+ expectUnmetRequirements([ getPlatformRequirement('~5.0.0') ]);
+ });
+ });
+
+ it('Test 004 : should handle the case where there are no constraints for earliest releases', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '1.0.0': { 'cordova-android': '~5.0.0' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('0.7.0');
+ expectUnmetRequirements([ getPlatformRequirement('~5.0.0') ]);
+ });
+ });
+
+ it('Test 005 : should handle the case where the lowest version is unsatisfied', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '0.0.2': { 'cordova-android': '~5.0.0' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe(null);
+ expectUnmetRequirements([ getPlatformRequirement('~5.0.0') ]);
+ });
+ });
+
+ it('Test 006 : should handle upperbounds if no single version constraints are given', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '<1.0.0': { 'cordova-android': '<2.0.0' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('2.3.0');
+ expectUnmetRequirements([]);
+ });
+ });
+
+ it('Test 007 : should apply upper bounds greater than highest version', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '0.0.0': {},
+ '<5.0.0': { 'cordova-android': '<2.0.0' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe(null);
+ expectUnmetRequirements([ getPlatformRequirement('<2.0.0') ]);
+ });
+ });
+
+ it('Test 008 : should treat empty constraints as satisfied', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '1.0.0': {},
+ '1.1.0': { 'cordova-android': '>5.0.0' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('1.0.0');
+ expectUnmetRequirements([ getPlatformRequirement('>5.0.0') ]);
+ });
+ });
+
+ it('Test 009 : should ignore an empty cordovaDependencies entry', () => {
+ testPlugin.engines.cordovaDependencies = {};
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe(null);
+ expectUnmetRequirements([]);
+ });
+ });
+
+ it('Test 010 : should ignore a badly formatted semver range', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '1.1.3': { 'cordova-android': 'badSemverRange' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('2.3.0');
+ expectUnmetRequirements([]);
+ });
+ });
+
+ it('Test 011 : should respect unreleased versions in constraints', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '1.0.0': { 'cordova-android': '3.1.0' },
+ '1.1.2': { 'cordova-android': '6.1.1' },
+ '1.3.0': { 'cordova-android': '6.1.1' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('1.1.0');
+ expectUnmetRequirements([ getPlatformRequirement('6.1.1') ]);
+ });
+ });
+
+ it('Test 012 : should respect plugin constraints', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '0.0.0': { 'ca.filmaj.AndroidPlugin': '1.2.0' },
+ '1.1.3': { 'ca.filmaj.AndroidPlugin': '<5.0.0 || >2.3.0' },
+ '2.3.0': { 'ca.filmaj.AndroidPlugin': '6.1.1' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('2.0.0');
+ expectUnmetRequirements([ getPluginRequirement('6.1.1') ]);
+ });
+ });
+
+ it('Test 013 : should respect cordova constraints', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '0.0.0': { 'cordova': '>1.0.0' },
+ '1.1.3': { 'cordova': '<3.0.0 || >4.0.0' },
+ '2.3.0': { 'cordova': '6.1.1' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('1.1.0');
+ expectUnmetRequirements([ getCordovaRequirement('6.1.1') ]);
+ });
+ });
+
+ it('Test 014 : should not include pre-release versions', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '0.0.0': {},
+ '2.0.0': { 'cordova-android': '>5.0.0' }
+ };
+
+ // Should not return 2.0.0-rc.2
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('1.7.1');
+ expectUnmetRequirements([ getPlatformRequirement('>5.0.0') ]);
+ });
+ });
+
+ it('Test 015 : should not fail if there is no engine in the npm info', () => {
+ delete testPlugin.engines;
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe(null);
+ expectUnmetRequirements([]);
+ });
+ });
+
+ it('Test 016 : should not fail if there is no cordovaDependencies in the engines', () => {
+ testPlugin.engines = {
+ 'node': '>7.0.0',
+ 'npm': '~2.0.0'
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe(null);
+ expectUnmetRequirements([]);
+ });
+ });
+
+ it('Test 017 : should handle extra whitespace', () => {
+ testPlugin.engines.cordovaDependencies = {
+ ' 1.0.0 ': {},
+ '2.0.0 ': { ' cordova-android': '~5.0.0 ' },
+ ' < 1.0.0\t': { ' cordova-android ': ' > 5.0.0' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('1.7.1');
+ expectUnmetRequirements([ getPlatformRequirement('~5.0.0') ]);
+ });
+ });
+
+ it('Test 018 : should ignore badly typed version requirement entries', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '1.1.0': ['cordova', '5.0.0'],
+ '1.3.0': undefined,
+ '1.7.0': null
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('2.3.0');
+ expectUnmetRequirements([]);
+ });
+ });
+
+ it('Test 019 : should ignore badly typed constraint entries', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '0.0.2': { 'cordova': 1 },
+ '0.7.0': { 'cordova': {} },
+ '1.0.0': { 'cordova': undefined },
+ '1.1.3': { 8: '5.0.0' },
+ '1.3.0': { 'cordova': [] },
+ '1.7.1': { 'cordova': null }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('2.3.0');
+ expectUnmetRequirements([]);
+ });
+ });
+
+ it('Test 020 : should ignore bad semver versions', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '0.0.0': { 'cordova-android': '5.0.0' },
+ 'notAVersion': { 'cordova-android': '3.1.0' },
+ '^1.1.2': { 'cordova-android': '3.1.0' },
+ '<=1.3.0': { 'cordova-android': '3.1.0' },
+ '1.0': { 'cordova-android': '3.1.0' },
+ '2': { 'cordova-android': '3.1.0' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe(null);
+ expectUnmetRequirements([ getPlatformRequirement('5.0.0') ]);
+ });
+ });
+
+ it('Test 021 : should not fail if there are bad semver versions', () => {
+ testPlugin.engines.cordovaDependencies = {
+ 'notAVersion': { 'cordova-android': '3.1.0' },
+ '^1.1.2': { 'cordova-android': '3.1.0' },
+ '<=1.3.0': { 'cordova-android': '3.1.0' },
+ '1.0.0': { 'cordova-android': '~3' }, // Good semver
+ '2.0.0': { 'cordova-android': '5.1.0' }, // Good semver
+ '1.0': { 'cordova-android': '3.1.0' },
+ '2': { 'cordova-android': '3.1.0' }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('1.7.1');
+ expectUnmetRequirements([ getPlatformRequirement('5.1.0') ]);
+ });
+ });
+
+ it('Test 022 : should properly warn about multiple unmet requirements', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '1.7.0': {
+ 'cordova-android': '>5.1.0',
+ 'ca.filmaj.AndroidPlugin': '3.1.0',
+ 'cordova': '3.4.2'
+ }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('1.3.0');
+ expectUnmetRequirements([
+ getPlatformRequirement('>5.1.0'),
+ getPluginRequirement('3.1.0')
+ ]);
+ });
+ });
+
+ it('Test 023 : should properly warn about both unmet latest and upper bound requirements', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '1.7.0': { 'cordova-android': '>5.1.0' },
+ '<5.0.0': {
+ 'cordova-android': '>7.1.0',
+ 'ca.filmaj.AndroidPlugin': '3.1.0'
+ }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe(null);
+ expectUnmetRequirements([
+ getPlatformRequirement('>5.1.0 AND >7.1.0'),
+ getPluginRequirement('3.1.0')
+ ]);
+ });
+ });
+
+ it('Test 024 : should not warn about versions past latest', () => {
+ testPlugin.engines.cordovaDependencies = {
+ '1.7.0': { 'cordova-android': '>5.1.0' },
+ '7.0.0': {
+ 'cordova-android': '>7.1.0',
+ 'ca.filmaj.AndroidPlugin': '3.1.0'
+ }
+ };
+
+ return getFetchVersion(testPlugin).then(version => {
+ expect(version).toBe('1.3.0');
+ expectUnmetRequirements([ getPlatformRequirement('>5.1.0') ]);
+ });
+ });
+});
diff --git a/spec/cordova/plugin/add.spec.js b/spec/cordova/plugin/add.spec.js
index c135e96..45b7c57 100644
--- a/spec/cordova/plugin/add.spec.js
+++ b/spec/cordova/plugin/add.spec.js
@@ -363,8 +363,8 @@ describe('cordova/plugin/add', function () {
});
// TODO: reorganize these tests once the logic here is understood! -filmaj
- // TODO: rewrite the tests from integration-tests/plugin_fetch.spec.js to here.
describe('unit tests to replace integration-tests/plugin_fetch.spec.js', function () {
+ // See also the tests in spec/cordova/plugin/add.getFetchVersion.spec.js
describe('getFetchVersion helper method', function () {
var pluginInfo;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org