You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2015/04/24 01:56:08 UTC

[GitHub] cordova-lib pull request: Update elementtree dependency to 0.1.6. ...

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-lib/pull/209

    Update elementtree dependency to 0.1.6. Note it has a breaking API chang...

    ...e. https://github.com/racker/node-elementtree/issues/24

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-lib elementtree-0.1.6-update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #209
    
----
commit 60ea35ea0b1df9c2a0d59af6f817fc45941036c3
Author: Shazron Abdullah <sh...@apache.org>
Date:   2015-04-23T23:55:40Z

    Update elementtree dependency to 0.1.6. Note it has a breaking API change. https://github.com/racker/node-elementtree/issues/24

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib pull request: Update elementtree dependency to 0.1.6. ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-lib/pull/209


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib pull request: Update elementtree dependency to 0.1.6. ...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-lib/pull/209#issuecomment-98900067
  
    Great - I'll merge this in tomorrow. The only impact I see is if a plugin require'd elementtree in its hooks and is using the old delete API, but that's not something we can really control.
    
    They'll just have to do something like: https://github.com/apache/cordova-plugins/blob/bef0942b8fab7778caf8bf3770c13fd9a8c6e11c/local-webserver/scripts/before_uninstall.js#L51-L57



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org