You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2021/07/22 22:47:39 UTC
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17716
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
A new added testcase in TestTPCHJoinQueries.test_outer_joins
can't pass the s3 build because the plan generated in s3 build
is not the same as the default hdfs build for the scan node. In
s3 build, it is "SCAN S3", while in hdfs build, it is "SCAN HDFS".
The patch changed the comparison in the test to use regular
expression to skip the difference of HDFS and S3.
Tests:
Reran failed testcase.
Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
---
M testdata/workloads/tpch/queries/tpch-outer-joins.test
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/17716/1
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9172/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 16:25:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17716/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17716/2//COMMIT_MSG@15
PS2, Line 15: will be changed according to the file system the testcase is
> Comment probably needs to be updated to reflect the latest fix.
Done
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 16:08:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17716/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17716/2//COMMIT_MSG@15
PS2, Line 15: expression to skip the difference of HDFS and S3.
Comment probably needs to be updated to reflect the latest fix.
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 15:40:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
A new added testcase in TestTPCHJoinQueries.test_outer_joins
can't pass the s3 build because the plan generated in s3 build
is not the same as the default hdfs build for the scan node. In
s3 build, it is "SCAN S3", while in hdfs build, it is "SCAN HDFS".
The patch changed the testcase to use $FILESYSTEM_NAME, which
will be changed according to the file system the testcase is
using.
Tests:
Reran and passed the failed testcase in s3 build.
Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Reviewed-on: http://gerrit.cloudera.org:8080/17716
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/tpch/queries/tpch-outer-joins.test
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 5
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7349/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 16:14:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17716/1/testdata/workloads/tpch/queries/tpch-outer-joins.test
File testdata/workloads/tpch/queries/tpch-outer-joins.test:
http://gerrit.cloudera.org:8080/#/c/17716/1/testdata/workloads/tpch/queries/tpch-outer-joins.test@87
PS1, Line 87: '| 00:SC
> Yes, it's better to use $FILESYSTEM_NAME.
Done
http://gerrit.cloudera.org:8080/#/c/17716/1/testdata/workloads/tpch/queries/tpch-outer-joins.test@87
PS1, Line 87: '| 00:SC
> You could also use $FILESYSTEM_NAME here instead of regex.
Yeah, $FILESYSTEM_NAME is better, thanks for the advice. Done.
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 24 Jul 2021 03:20:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17716/1/testdata/workloads/tpch/queries/tpch-outer-joins.test
File testdata/workloads/tpch/queries/tpch-outer-joins.test:
http://gerrit.cloudera.org:8080/#/c/17716/1/testdata/workloads/tpch/queries/tpch-outer-joins.test@87
PS1, Line 87: row_regex
You could also use $FILESYSTEM_NAME here instead of regex.
Here is an example:
https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test#L79
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Jul 2021 23:39:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9159/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 24 Jul 2021 03:40:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17716/1/testdata/workloads/tpch/queries/tpch-outer-joins.test
File testdata/workloads/tpch/queries/tpch-outer-joins.test:
http://gerrit.cloudera.org:8080/#/c/17716/1/testdata/workloads/tpch/queries/tpch-outer-joins.test@87
PS1, Line 87: row_regex
> You could also use $FILESYSTEM_NAME here instead of regex.
Yes, it's better to use $FILESYSTEM_NAME.
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 03:41:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9148/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Jul 2021 23:08:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
A new added testcase in TestTPCHJoinQueries.test_outer_joins
can't pass the s3 build because the plan generated in s3 build
is not the same as the default hdfs build for the scan node. In
s3 build, it is "SCAN S3", while in hdfs build, it is "SCAN HDFS".
The patch changed the comparison in the test to use regular
expression to skip the difference of HDFS and S3.
Tests:
Reran and passed the failed testcase in s3 build.
Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
---
M testdata/workloads/tpch/queries/tpch-outer-joins.test
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/17716/2
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 16:12:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Jul 2021 23:28:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
A new added testcase in TestTPCHJoinQueries.test_outer_joins
can't pass the s3 build because the plan generated in s3 build
is not the same as the default hdfs build for the scan node. In
s3 build, it is "SCAN S3", while in hdfs build, it is "SCAN HDFS".
The patch changed the testcase to use $FILESYSTEM_NAME, which
will be changed according to the file system the testcase is
using.
Tests:
Reran and passed the failed testcase in s3 build.
Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
---
M testdata/workloads/tpch/queries/tpch-outer-joins.test
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/17716/3
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 22:22:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 16:14:32 +0000
Gerrit-HasComments: No