You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amruth Sampath <am...@gmail.com> on 2015/11/03 07:37:53 UTC
Review Request 39891: Change /savedqueries/parameters call to POST
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39891/
-----------------------------------------------------------
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Repository: lens
Description
-------
This is necessary because if the query is large enough, the call fails, as in GET request the query goes as a url parameter.
This needs backend change also.
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java a7e0aef
Diff: https://reviews.apache.org/r/39891/diff/
Testing
-------
All test cases running fine.
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.901 s]
[INFO] Lens ............................................... SUCCESS [ 3.479 s]
[INFO] Lens API ........................................... SUCCESS [ 19.997 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 11.996 s]
[INFO] Lens Cube .......................................... SUCCESS [03:13 min]
[INFO] Lens DB storage .................................... SUCCESS [ 9.370 s]
[INFO] Lens Query Library ................................. SUCCESS [ 7.467 s]
[INFO] Lens Hive Driver ................................... SUCCESS [01:50 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 23.998 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 9.065 s]
[INFO] Lens Server ........................................ SUCCESS [07:14 min]
[INFO] Lens client ........................................ SUCCESS [ 22.785 s]
[INFO] Lens CLI ........................................... SUCCESS [ 32.873 s]
[INFO] Lens Examples ...................................... SUCCESS [ 4.037 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.367 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.072 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:02 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 1.961 s]
[INFO] Lens Regression .................................... SUCCESS [ 6.545 s]
[INFO] Lens UI ............................................ SUCCESS [ 2.865 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:09 min
[INFO] Finished at: 2015-11-03T12:02:48+05:30
[INFO] Final Memory: 160M/1708M
[INFO] ------------------------------------------------------------------------
Thanks,
Amruth Sampath
Re: Review Request 39891: Change /savedqueries/parameters call to POST
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39891/#review104890
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Nov. 3, 2015, 12:07 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39891/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 12:07 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> This is necessary because if the query is large enough, the call fails, as in GET request the query goes as a url parameter.
> This needs backend change also.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java a7e0aef
>
> Diff: https://reviews.apache.org/r/39891/diff/
>
>
> Testing
> -------
>
> All test cases running fine.
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.901 s]
> [INFO] Lens ............................................... SUCCESS [ 3.479 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.997 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 11.996 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:13 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 9.370 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 7.467 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [01:50 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 23.998 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 9.065 s]
> [INFO] Lens Server ........................................ SUCCESS [07:14 min]
> [INFO] Lens client ........................................ SUCCESS [ 22.785 s]
> [INFO] Lens CLI ........................................... SUCCESS [ 32.873 s]
> [INFO] Lens Examples ...................................... SUCCESS [ 4.037 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.367 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.072 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:02 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 1.961 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.545 s]
> [INFO] Lens UI ............................................ SUCCESS [ 2.865 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 16:09 min
> [INFO] Finished at: 2015-11-03T12:02:48+05:30
> [INFO] Final Memory: 160M/1708M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amruth Sampath
>
>