You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/03/08 12:21:56 UTC
[Bug 5371] New: sa-update generates disordered channel_files: wrong include order
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5371
Summary: sa-update generates disordered channel_files: wrong
include order
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: All
OS/Version: All
Status: NEW
Severity: critical
Priority: P2
Component: sa-update
AssignedTo: dev@spamassassin.apache.org
ReportedBy: spamassassin-bugs@leo.0n3.org
the files to include are prefixed with numbers to grant the right include
order. sa-update generates disorderd include files like
/var/lib/spamassassin/3.001007/updates_spamassassin_org.cf
so the rules are included in the wrong order ...
One symptom is the malfunction of the language-support:
The report definition in 30_text_de.cf values would be overwritten by a displaced
10_misc.cf ...
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5371] sa-update generates disordered channel_files: wrong include order
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5371
------- Additional Comments From jm@jmason.org 2007-03-13 08:58 -------
+1 -- trivial fix, and it's always worth having these things in a predictable order.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5371] sa-update generates disordered channel_files: wrong include order
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5371
------- Additional Comments From spamassassin-bugs@leo.0n3.org 2007-03-08 03:27 -------
Created an attachment (id=3878)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3878&action=view)
channel file enty order sort patch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5371] sa-update generates disordered channel_files: wrong include order
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5371
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From jm@jmason.org 2007-03-15 06:37 -------
applied:
: jm 1061...; svn commit -m "bug 5371: sa-update could produce updates that load
files in the wrong order; sort alphanumerically to avoid this" sa-update.raw
Sending sa-update.raw
Transmitting file data .
Committed revision 518626.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5371] sa-update generates disordered channel_files: wrong include order
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5371
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.2.0
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5371] sa-update generates disordered channel_files: wrong include order
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5371
------- Additional Comments From spamassassin@dostech.ca 2007-03-09 12:33 -------
Just out of curiosity, what platform are you running on that opendir/readdir
doesn't give you the files in sorted order to begin with?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5371] sa-update generates disordered channel_files: wrong include order
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5371
spamassassin-bugs@leo.0n3.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|critical |major
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5371] sa-update generates disordered channel_files: wrong include order
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5371
------- Additional Comments From spamassassin@dostech.ca 2007-03-09 14:43 -------
(In reply to comment #3)
> (In reply to comment #2)
> > Just out of curiosity, what platform are you running on that opendir/readdir
> > doesn't give you the files in sorted order to begin with?
>
> That would be all platforms as far as I know. ;) Typically readdir just walks
> the directory entries, which will be in the order that the files were created
> (assuming no deletions/fragmentation).
Ha... apparently I knew that, looking now I've gots literally hundreds of
scripts that sort the files returned by readdir.
> Also typically, the update will have the tar file in order, and so the files are
> created in the directory in order.
I guess my question should have been, I wonder why Richard has seen this. I
can't find include files on my system that have the cf files out of order.
In any case, yeah, trivial fix that we need to do.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5371] sa-update generates disordered channel_files: wrong include order
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5371
------- Additional Comments From felicity@apache.org 2007-03-09 13:20 -------
(In reply to comment #2)
> Just out of curiosity, what platform are you running on that opendir/readdir
> doesn't give you the files in sorted order to begin with?
That would be all platforms as far as I know. ;) Typically readdir just walks
the directory entries, which will be in the order that the files were created
(assuming no deletions/fragmentation).
Also typically, the update will have the tar file in order, and so the files are
created in the directory in order.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.