You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Nicolaas Matthijs (JIRA)" <ji...@apache.org> on 2008/07/24 19:49:31 UTC
[jira] Created: (SHINDIG-471) Removed samplecontainer's duplicate
XhrHandling
Removed samplecontainer's duplicate XhrHandling
-----------------------------------------------
Key: SHINDIG-471
URL: https://issues.apache.org/jira/browse/SHINDIG-471
Project: Shindig
Issue Type: Improvement
Components: Sample container & Examples
Reporter: Nicolaas Matthijs
Attachments: xhr-replacement-io.patch
I've removed the samplecontainer's own XhrHandling and Reused the io.js XhrHandling
as stated in this line:
// Xhr stuff that is copied from io.js.
// TODO: We should really get rid of the duplication
This patch does require Shindig-465 to be applied first
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-471) Removed samplecontainer's duplicate
XhrHandling
Posted by "Nicolaas Matthijs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolaas Matthijs updated SHINDIG-471:
--------------------------------------
Attachment: xhr-replacement-io.patch
> Removed samplecontainer's duplicate XhrHandling
> -----------------------------------------------
>
> Key: SHINDIG-471
> URL: https://issues.apache.org/jira/browse/SHINDIG-471
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: xhr-replacement-io.patch
>
>
> I've removed the samplecontainer's own XhrHandling and Reused the io.js XhrHandling
> as stated in this line:
> // Xhr stuff that is copied from io.js.
> // TODO: We should really get rid of the duplication
> This patch does require Shindig-465 to be applied first
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-471) Removed samplecontainer's duplicate
XhrHandling
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cassie Doll resolved SHINDIG-471.
---------------------------------
Resolution: Fixed
Assignee: Cassie Doll
I also replaced the encodeValues function with gadget.io.encodeValues as that also came from the standard io.js.
> Removed samplecontainer's duplicate XhrHandling
> -----------------------------------------------
>
> Key: SHINDIG-471
> URL: https://issues.apache.org/jira/browse/SHINDIG-471
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Assignee: Cassie Doll
> Attachments: xhr-replacement-io-002.patch
>
>
> I've removed the samplecontainer's own XhrHandling and Reused the io.js XhrHandling
> as stated in this line:
> // Xhr stuff that is copied from io.js.
> // TODO: We should really get rid of the duplication
> This patch does require Shindig-465 to be applied first
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-471) Removed samplecontainer's duplicate
XhrHandling
Posted by "Nicolaas Matthijs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolaas Matthijs updated SHINDIG-471:
--------------------------------------
Attachment: (was: xhr-replacement-io.patch)
> Removed samplecontainer's duplicate XhrHandling
> -----------------------------------------------
>
> Key: SHINDIG-471
> URL: https://issues.apache.org/jira/browse/SHINDIG-471
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: xhr-replacement-io-002.patch
>
>
> I've removed the samplecontainer's own XhrHandling and Reused the io.js XhrHandling
> as stated in this line:
> // Xhr stuff that is copied from io.js.
> // TODO: We should really get rid of the duplication
> This patch does require Shindig-465 to be applied first
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-471) Removed samplecontainer's duplicate
XhrHandling
Posted by "Nicolaas Matthijs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolaas Matthijs updated SHINDIG-471:
--------------------------------------
Attachment: xhr-replacement-io.patch
Updated the patch by removing the permission changes on the files
> Removed samplecontainer's duplicate XhrHandling
> -----------------------------------------------
>
> Key: SHINDIG-471
> URL: https://issues.apache.org/jira/browse/SHINDIG-471
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: xhr-replacement-io.patch
>
>
> I've removed the samplecontainer's own XhrHandling and Reused the io.js XhrHandling
> as stated in this line:
> // Xhr stuff that is copied from io.js.
> // TODO: We should really get rid of the duplication
> This patch does require Shindig-465 to be applied first
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-471) Removed samplecontainer's duplicate
XhrHandling
Posted by "Nicolaas Matthijs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolaas Matthijs updated SHINDIG-471:
--------------------------------------
Attachment: xhr-replacement-io-002.patch
Adjusted the patch so that it works with "patch -p0" in stead of "patch -p1".
> Removed samplecontainer's duplicate XhrHandling
> -----------------------------------------------
>
> Key: SHINDIG-471
> URL: https://issues.apache.org/jira/browse/SHINDIG-471
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: xhr-replacement-io-002.patch
>
>
> I've removed the samplecontainer's own XhrHandling and Reused the io.js XhrHandling
> as stated in this line:
> // Xhr stuff that is copied from io.js.
> // TODO: We should really get rid of the duplication
> This patch does require Shindig-465 to be applied first
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-471) Removed samplecontainer's duplicate
XhrHandling
Posted by "Nicolaas Matthijs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolaas Matthijs updated SHINDIG-471:
--------------------------------------
Attachment: (was: xhr-replacement-io.patch)
> Removed samplecontainer's duplicate XhrHandling
> -----------------------------------------------
>
> Key: SHINDIG-471
> URL: https://issues.apache.org/jira/browse/SHINDIG-471
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
>
> I've removed the samplecontainer's own XhrHandling and Reused the io.js XhrHandling
> as stated in this line:
> // Xhr stuff that is copied from io.js.
> // TODO: We should really get rid of the duplication
> This patch does require Shindig-465 to be applied first
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.