You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/19 08:43:54 UTC
[GitHub] [rocketmq] rushsky518 opened a new pull request #1779: remove
redundant code
rushsky518 opened a new pull request #1779: remove redundant code
URL: https://github.com/apache/rocketmq/pull/1779
optimize DefaultMessageStore.CleanCommitLogService#deleteExpiredFiles
remove redundant code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] xujianhai666 commented on issue #1779:
"CleanCommitLogService#deleteExpiredFiles", remove redundant code
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on issue #1779: "CleanCommitLogService#deleteExpiredFiles", remove redundant code
URL: https://github.com/apache/rocketmq/pull/1779#issuecomment-592926670
@rushsky518 The code is okay, the more refer by https://github.com/apache/rocketmq/wiki/RIP-14-RocketMQ-Git-Commit-Message-Conventions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] rushsky518 closed pull request #1779:
"CleanCommitLogService#deleteExpiredFiles", remove redundant code
Posted by GitBox <gi...@apache.org>.
rushsky518 closed pull request #1779: "CleanCommitLogService#deleteExpiredFiles", remove redundant code
URL: https://github.com/apache/rocketmq/pull/1779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1779:
"CleanCommitLogService#deleteExpiredFiles", remove redundant code
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1779: "CleanCommitLogService#deleteExpiredFiles", remove redundant code
URL: https://github.com/apache/rocketmq/pull/1779#issuecomment-588145319
[](https://coveralls.io/builds/28821495)
Coverage decreased (-0.06%) to 50.934% when pulling **8b8a8cc8a2887414550c8c6db3276872f9daf632 on rushsky518:deleteFiles** into **35c38888e0d5678fb4aaad5ba8534b7552d9a9a0 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services